Peter Eisentraut wrote:
On m?n, 2011-05-23 at 20:50 -0400, Aaron W. Swenson wrote:
According to Linux Standard Base Core Specification 3.1 [1], the exit
status should be '3' when the server isn't running.
I've attached a very simple patch that resolves this cosmetic issue,
which applies to all branches.
If we're going to make the exit status meaningful, it should probably be
added to the documentation.
Patch attached and applied, with docs. I also cleaned up some C
comments, which are not in the attached patch.
--
Bruce Momjian br...@momjian.ushttp://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
diff --git a/doc/src/sgml/ref/pg_ctl-ref.sgml b/doc/src/sgml/ref/pg_ctl-ref.sgml
new file mode 100644
index 07836e7..7dc170e
*** a/doc/src/sgml/ref/pg_ctl-ref.sgml
--- b/doc/src/sgml/ref/pg_ctl-ref.sgml
*** PostgreSQL documentation
*** 205,211
optionstatus/option mode checks whether a server is running in
the specified data directory. If it is, the acronymPID/acronym
and the command line options that were used to invoke it are
!displayed.
/para
para
--- 205,212
optionstatus/option mode checks whether a server is running in
the specified data directory. If it is, the acronymPID/acronym
and the command line options that were used to invoke it are
!displayed. If the server is not running, the process returns an
!exit status of 3.
/para
para
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
new file mode 100644
index c9007ed..8e9d2ce
*** a/src/bin/pg_ctl/pg_ctl.c
--- b/src/bin/pg_ctl/pg_ctl.c
*** do_status(void)
*** 1186,1192
}
}
printf(_(%s: no server running\n), progname);
! exit(1);
}
--- 1188,1198
}
}
printf(_(%s: no server running\n), progname);
! /*
! * The Linux Standard Base Core Specification 3.1 says this should return '3'
! * http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
! */
! exit(3);
}
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
