Re: [HACKERS] Comment and function argument names are mismatched in bugmgr.c.
On Sat, Jul 2, 2016 at 6:34 AM, Andres Freund wrote: > Hi, > > On 2016-06-23 16:24:12 +0900, Masahiko Sawada wrote: >> By commit 428b1d6b, function WritebackContextInit is added but the >> comment of this function seems to be incorrect. >> *max_coalesce variable doesn't exist at anywhere. >> Also, I think it should be fixed that the argument name of this >> function does not match function declare in buf_internal.h. >> Patch for that attached. > > Fix looks good to me, and your 'bugmgr.c' typo in $subject made me laugh > ;). Pushed. Oops, I realized it now :) Thanks! Regards, -- Masahiko Sawada -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Comment and function argument names are mismatched in bugmgr.c.
Hi, On 2016-06-23 16:24:12 +0900, Masahiko Sawada wrote: > By commit 428b1d6b, function WritebackContextInit is added but the > comment of this function seems to be incorrect. > *max_coalesce variable doesn't exist at anywhere. > Also, I think it should be fixed that the argument name of this > function does not match function declare in buf_internal.h. > Patch for that attached. Fix looks good to me, and your 'bugmgr.c' typo in $subject made me laugh ;). Pushed. Thanks Robert, for pointing me to the thread, I had indeed missed it. Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Comment and function argument names are mismatched in bugmgr.c.
On Thu, Jun 23, 2016 at 3:24 AM, Masahiko Sawada wrote: > By commit 428b1d6b, function WritebackContextInit is added but the > comment of this function seems to be incorrect. > *max_coalesce variable doesn't exist at anywhere. > Also, I think it should be fixed that the argument name of this > function does not match function declare in buf_internal.h. > Patch for that attached. Andres, this looks like one for you to handle. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
