Re: [HACKERS] Comparison with true in source code

2010-11-14 Thread Robert Haas
On Wed, Nov 3, 2010 at 9:45 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Wed, Nov 3, 2010 at 2:19 AM, Michael Meskes mes...@postgresql.org wrote: On Mon, Nov 01, 2010 at 12:17:02PM +0900, Itagaki Takahiro wrote: There are some == true in the codes, but they might not be safe

Re: [HACKERS] Comparison with true in source code

2010-11-14 Thread Itagaki Takahiro
On Mon, Nov 15, 2010 at 11:13, Robert Haas robertmh...@gmail.com wrote: I added an additional cleanup to 'header_mode' in ecpg; I changed the type from bool to char to hold 'h' or 'c'. Do you think it is reasonable? I looked at this but found that part a bit too clever for its own good. So

Re: [HACKERS] Comparison with true in source code

2010-11-04 Thread Robert Haas
On Wed, Nov 3, 2010 at 6:45 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Wed, Nov 3, 2010 at 2:19 AM, Michael Meskes mes...@postgresql.org wrote: On Mon, Nov 01, 2010 at 12:17:02PM +0900, Itagaki Takahiro wrote: There are some == true in the codes, but they might not be safe

Re: [HACKERS] Comparison with true in source code

2010-11-03 Thread Itagaki Takahiro
On Wed, Nov 3, 2010 at 2:19 AM, Michael Meskes mes...@postgresql.org wrote: On Mon, Nov 01, 2010 at 12:17:02PM +0900, Itagaki Takahiro wrote: There are some == true in the codes, but they might not be safe because all non-zero values are true in C. Is it worth cleaning up them? Here is a

Re: [HACKERS] Comparison with true in source code

2010-11-02 Thread Michael Meskes
On Mon, Nov 01, 2010 at 12:17:02PM +0900, Itagaki Takahiro wrote: There are some == true in the codes, but they might not be safe because all non-zero values are true in C. Is it worth cleaning up them? ... src/interfaces/ecpg/ecpglib/connect.c(168): if (con-autocommit == true