Re: [HACKERS] Corner case in xlog stuff: what happens exactly at a seg boundary?

2006-08-07 Thread Tom Lane
"Jim C. Nasby" <[EMAIL PROTECTED]> writes: > Should we ask users if anyone is currently doing this? It seems pretty > ugly to have most functions return the last used WAL byte with only > stop_backup returning the first unused byte. No, you misunderstood. All the functions that return WAL locatio

Re: [HACKERS] Corner case in xlog stuff: what happens exactly at a seg boundary?

2006-08-07 Thread Jim C. Nasby
On Sat, Aug 05, 2006 at 11:59:40PM -0400, Tom Lane wrote: > I wrote: > > Rather than expecting user-level scripts to get this corner case > > right, I suggest that we ought to modify pg_stop_backup and friends > > so that what they return is the last used byte address of WAL, not > > the first unus

Re: [HACKERS] Corner case in xlog stuff: what happens exactly at a seg boundary?

2006-08-07 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Sat, 2006-08-05 at 23:59 -0400, Tom Lane wrote: >> After further thought I desisted from that plan: changing the result >> convention of existing functions like pg_stop_backup() will break any >> existing archiving scripts that do get it right. Instead,

Re: [HACKERS] Corner case in xlog stuff: what happens exactly at a seg boundary?

2006-08-05 Thread Tom Lane
I wrote: > Rather than expecting user-level scripts to get this corner case > right, I suggest that we ought to modify pg_stop_backup and friends > so that what they return is the last used byte address of WAL, not > the first unused byte address as now. Then, blindly extracting > the filename wil