Re: [HACKERS] crash-recovery test vs windows

2017-09-28 Thread Andrew Dunstan
On 09/28/2017 12:29 PM, Andrew Dunstan wrote: > The new crash-recovery check is failing pretty reliably on jacana. It's > already excluded on MSVC machines, so I'm inclined to exclude it on Msys > as well. > > Sorry, I meant crash-restart cheers andrew -- Andrew Dunstan

Re: [HACKERS] Crash recovery

2013-11-05 Thread Heikki Linnakangas
On 05.11.2013 13:21, Soroosh Sardari wrote: When PG crashes or the computer turned down unexpectedly, next time postmaster starts up, it does the crash recovery, actually redo xlog records, vacuum, etc. What module is responsible for crash recovery? See src/backend/access/transam/xlog.c. The

Re: [HACKERS] crash-recovery replay of CREATE TABLESPACE is broken in HEAD

2010-07-20 Thread Bruce Momjian
Bruce Momjian wrote: Bruce Momjian wrote: The attached patch does as suggested. I added the recovery code to the create tablespace function so I didn't have to duplicate all the code that computes the path names. Attached. Uh, another question. Looking at the createdb

Re: [HACKERS] crash-recovery replay of CREATE TABLESPACE is broken in HEAD

2010-07-18 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Maybe you should check that it points to the right location? Or drop and recreate the symlink, and ignore failure at mkdir. More specifically, ignore EEXIST failure when replaying mkdir. Anything else is still a problem.

Re: [HACKERS] crash-recovery replay of CREATE TABLESPACE is broken in HEAD

2010-07-18 Thread Bruce Momjian
Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Maybe you should check that it points to the right location? Or drop and recreate the symlink, and ignore failure at mkdir. More specifically, ignore EEXIST failure when replaying mkdir. Anything else is

Re: [HACKERS] crash-recovery replay of CREATE TABLESPACE is broken in HEAD

2010-07-18 Thread Bruce Momjian
Bruce Momjian wrote: Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Maybe you should check that it points to the right location? Or drop and recreate the symlink, and ignore failure at mkdir. More specifically, ignore EEXIST failure when replaying

Re: [HACKERS] crash-recovery replay of CREATE TABLESPACE is broken in HEAD

2010-07-18 Thread Bruce Momjian
Bruce Momjian wrote: The attached patch does as suggested. I added the recovery code to the create tablespace function so I didn't have to duplicate all the code that computes the path names. Attached. Uh, another question. Looking at the createdb recovery, I see: /*

Re: [HACKERS] crash-recovery replay of CREATE TABLESPACE is broken in HEAD

2010-07-17 Thread Bruce Momjian
Tom Lane wrote: I managed to crash the executor in the tablespace.sql test while working on a 9.1 patch, and discovered that the postmaster fails to recover from that. The end of postmaster.log looks like LOG: all server processes terminated; reinitializing LOG: database system was

Re: [HACKERS] crash-recovery replay of CREATE TABLESPACE is broken in HEAD

2010-07-17 Thread Heikki Linnakangas
On 18/07/10 08:22, Bruce Momjian wrote: The bug is that we can't replay mkdir()/symlink() and assume those will always succeed. I looked at the createdb redo code and it basically drops the directory before creating it. The tablespace directory/symlink setup is more complex, so I just wrote