Re: [HACKERS] Dropping OID column
I guess I'd prefer the DROP COLUMN syntax. It means we don't have to add another non-standard command, and people can figure out how to drop the oid column just by trying... Chris > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Rod Taylor > Sent: Friday, 17 January 2003 2:42 AM > To: PostgreSQL-development > Subject: [HACKERS] Dropping OID column > > > What is the preferred syntax: > > ALTER TABLE .. DROP COLUMN oid; > > or > > ALTER TABLE .. SET WITHOUT OIDS; > -- > Rod Taylor <[EMAIL PROTECTED]> > > PGP Key: http://www.rbt.ca/rbtpub.asc > ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [HACKERS] Dropping OID column
Tom Lane writes: > If we ever got around to supporting the inverse function (add oids), > I do not think we'd want to spell it like "ADD COLUMN oid" --- that > would interfere with making a plain user column named "oid", which was > one of the reasons why people wanted to be able to drop OIDs in the > first place. Is there really a reason why OIDs can't be a pure user-space column? -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [HACKERS] Dropping OID column
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Is there really a reason why OIDs can't be a pure user-space column? We'd need some kluge to keep "SELECT *" from including OID. Also I'd be a bit worried about the impact on the cost of HeapTupleGetOid --- it might not matter, or it might. regards, tom lane ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [HACKERS] Dropping OID column
Rod Taylor <[EMAIL PROTECTED]> writes: > What is the preferred syntax: > ALTER TABLE .. DROP COLUMN oid; > or > ALTER TABLE .. SET WITHOUT OIDS; If we ever got around to supporting the inverse function (add oids), I do not think we'd want to spell it like "ADD COLUMN oid" --- that would interfere with making a plain user column named "oid", which was one of the reasons why people wanted to be able to drop OIDs in the first place. So I lean towards the SET WITH/WITHOUT OIDS syntax. That keeps it clearly out of the domain of user columns. regards, tom lane ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [HACKERS] Dropping OID column
On Thu, 2003-01-16 at 13:41, Rod Taylor wrote: > ALTER TABLE .. SET WITHOUT OIDS; I'd prefer this, as it's more similar to the CREATE TABLE syntax. Cheers, Neil -- Neil Conway <[EMAIL PROTECTED]> || PGP Key ID: DB3C29FC ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/users-lounge/docs/faq.html