Re: [HACKERS] Fast promotion, loose ends

2013-04-24 Thread Heikki Linnakangas
On 22.04.2013 18:44, Simon Riggs wrote: On 22 April 2013 09:29, Heikki Linnakangashlinnakan...@vmware.com wrote: Hmm. That requires write access to $DATADIR, so that's not quite the same thing as the trigger_file recovery.conf option. Well, you also (elsewhere) requested that we must keep

Re: [HACKERS] Fast promotion, loose ends

2013-04-24 Thread Simon Riggs
On 24 April 2013 08:23, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 22.04.2013 18:44, Simon Riggs wrote: On 22 April 2013 09:29, Heikki Linnakangashlinnakan...@vmware.com wrote: Hmm. That requires write access to $DATADIR, so that's not quite the same thing as the trigger_file

Re: [HACKERS] Fast promotion, loose ends

2013-04-24 Thread Heikki Linnakangas
On 24.04.2013 10:57, Simon Riggs wrote: On 24 April 2013 08:23, Heikki Linnakangashlinnakan...@vmware.com wrote: On 22.04.2013 18:44, Simon Riggs wrote: On 22 April 2013 09:29, Heikki Linnakangashlinnakan...@vmware.com wrote: Hmm. That requires write access to $DATADIR, so that's not quite

Re: [HACKERS] Fast promotion, loose ends

2013-04-24 Thread Simon Riggs
On 24 April 2013 09:10, Heikki Linnakangas hlinnakan...@vmware.com wrote: Regarding the change in pg_ctl: /* -* Use two different kinds of promotion file so we can understand -* the difference between smart and fast promotion. +* For 9.3 onwards, use fast

Re: [HACKERS] Fast promotion, loose ends

2013-04-24 Thread Heikki Linnakangas
On 24.04.2013 11:23, Simon Riggs wrote: On 24 April 2013 09:10, Heikki Linnakangashlinnakan...@vmware.com wrote: Regarding the change in pg_ctl: /* -* Use two different kinds of promotion file so we can understand -* the difference between smart and fast promotion. +

Re: [HACKERS] Fast promotion, loose ends

2013-04-24 Thread Simon Riggs
On 24 April 2013 09:32, Heikki Linnakangas hlinnakan...@vmware.com wrote: pg_ctl already checks versions, so I don't see the point. The point is, if you do pgsql93/bin/pg_ctl -D $92DATADIR promote, it will create fast_promote file and return success. But it won't actually promote the

Re: [HACKERS] Fast promotion, loose ends

2013-04-24 Thread Heikki Linnakangas
On 24.04.2013 11:46, Simon Riggs wrote: On 24 April 2013 09:32, Heikki Linnakangashlinnakan...@vmware.com wrote: pg_ctl already checks versions, so I don't see the point. The point is, if you do pgsql93/bin/pg_ctl -D $92DATADIR promote, it will create fast_promote file and return success.

Re: [HACKERS] Fast promotion, loose ends

2013-04-24 Thread Simon Riggs
On 24 April 2013 09:53, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 24.04.2013 11:46, Simon Riggs wrote: On 24 April 2013 09:32, Heikki Linnakangashlinnakan...@vmware.com wrote: pg_ctl already checks versions, so I don't see the point. The point is, if you do pgsql93/bin/pg_ctl

Re: [HACKERS] Fast promotion, loose ends

2013-04-22 Thread Simon Riggs
On 22 April 2013 08:13, Heikki Linnakangas hlinnakan...@vmware.com wrote: We never reached a consensus on the user interface of the new 'fast promotion'. We should settle that before beta. The thread died here:

Re: [HACKERS] Fast promotion, loose ends

2013-04-22 Thread Heikki Linnakangas
On 22.04.2013 10:58, Simon Riggs wrote: On 22 April 2013 08:13, Heikki Linnakangashlinnakan...@vmware.com wrote: 2. There is no way to perform 'fast promotion' using the trigger file. That feature is only available using pg_ctl promote. When pg_ctl promote was introduced, it was not meant to

Re: [HACKERS] Fast promotion, loose ends

2013-04-22 Thread Shaun Thomas
On 04/22/2013 02:58 AM, Simon Riggs wrote: So, to initiate promotion, you can create a file called $DATADIR/fast_promote or $DATADIR/promote Pardon my naiveté, but could it also be an option to read the method from the promotion file? echo slow /my/promotion/path That would work without

Re: [HACKERS] Fast promotion, loose ends

2013-04-22 Thread Simon Riggs
On 22 April 2013 09:29, Heikki Linnakangas hlinnakan...@vmware.com wrote: Hmm. That requires write access to $DATADIR, so that's not quite the same thing as the trigger_file recovery.conf option. Well, you also (elsewhere) requested that we must keep recovery.conf in $DATADIR, so it needs to

Re: [HACKERS] Fast promotion, loose ends

2013-04-22 Thread Simon Riggs
On 22 April 2013 16:09, Shaun Thomas stho...@optionshouse.com wrote: On 04/22/2013 02:58 AM, Simon Riggs wrote: So, to initiate promotion, you can create a file called $DATADIR/fast_promote or $DATADIR/promote Pardon my naiveté, but could it also be an option to read the method from the

Re: [HACKERS] Fast promotion, loose ends

2013-04-22 Thread Heikki Linnakangas
On 22.04.2013 18:45, Simon Riggs wrote: On 22 April 2013 16:09, Shaun Thomasstho...@optionshouse.com wrote: On 04/22/2013 02:58 AM, Simon Riggs wrote: So, to initiate promotion, you can create a file called $DATADIR/fast_promote or $DATADIR/promote Pardon my naiveté, but could it also be

Re: [HACKERS] Fast promotion, loose ends

2013-04-22 Thread Simon Riggs
On 22 April 2013 19:04, Heikki Linnakangas hlinnakan...@vmware.com wrote: We could do that and a similar mechanism existed in pg_standby, but was removed in 9.0. That code is still in pg_standby. Maybe you were thinking of some other feature? It wasn't removed from pg_standby. But since