Re: [HACKERS] Fix picksplit with nan values

2014-02-05 Thread Alexander Korotkov
On Sat, Feb 1, 2014 at 7:50 AM, Bruce Momjian br...@momjian.us wrote: Where are we on this? I found myself to have empty draft letter from November with new version of patch attached. I'll return here when we have some solution in gin fast scan challenge. -- With best regards, Alexander

Re: [HACKERS] Fix picksplit with nan values

2014-01-31 Thread Bruce Momjian
Where are we on this? --- On Fri, Nov 8, 2013 at 01:38:28PM -0500, Tom Lane wrote: Alexander Korotkov aekorot...@gmail.com writes: I wrote attached patch by following principles: 1) NaN coordinates shouldn't crash or

Re: [HACKERS] Fix picksplit with nan values

2013-11-08 Thread Tom Lane
Alexander Korotkov aekorot...@gmail.com writes: Thanks, Andrew! Good spot. I didn't examine order by operators for work with NaNs. I think this time problem is in GiST itself rather than in opclass. I'm going to fix it in a separate patch. Attached patch fixes knn GiST behaviour with NaN. It

Re: [HACKERS] Fix picksplit with nan values

2013-11-08 Thread Tom Lane
Alexander Korotkov aekorot...@gmail.com writes: I wrote attached patch by following principles: 1) NaN coordinates shouldn't crash or hang GiST. 2) NaN coordinates should be processed in GiST index scan like in sequential scan. 3) NaN coordinates shouldn't lead to significant slowdown. I

Re: [HACKERS] Fix picksplit with nan values

2013-09-18 Thread Alexander Korotkov
On Tue, Sep 17, 2013 at 5:04 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Mon, Sep 16, 2013 at 4:13 PM, Andrew Gierth and...@tao11.riddles.org.uk wrote: Alexander == Alexander Korotkov aekorot...@gmail.com writes: Alexander 2) NaN coordinates should be processed in GiST index

Re: [HACKERS] Fix picksplit with nan values

2013-09-17 Thread Alexander Korotkov
On Mon, Sep 16, 2013 at 4:13 PM, Andrew Gierth and...@tao11.riddles.org.ukwrote: Alexander == Alexander Korotkov aekorot...@gmail.com writes: Alexander 2) NaN coordinates should be processed in GiST index scan Alexander like in sequential scan. postgres=# select * from pts order by a -

Re: [HACKERS] Fix picksplit with nan values

2013-09-16 Thread Andrew Gierth
Alexander == Alexander Korotkov aekorot...@gmail.com writes: Alexander 2) NaN coordinates should be processed in GiST index scan Alexander like in sequential scan. postgres=# select * from pts order by a - '(0,0)' limit 10; a -- (1,1) (7,nan) (9,nan) (11,nan) (4,nan)

Re: [HACKERS] Fix picksplit with nan values

2013-09-08 Thread Alexander Korotkov
On Sat, Sep 7, 2013 at 1:47 AM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov aekorot...@gmail.com writes: PostGIS spotted that picksplit algorithm freezes in infinite loop when dealing with nan values. I discovered same bug is present in core opclasses. Attached patch fixes this

Re: [HACKERS] Fix picksplit with nan values

2013-09-06 Thread Tom Lane
Alexander Korotkov aekorot...@gmail.com writes: PostGIS spotted that picksplit algorithm freezes in infinite loop when dealing with nan values. I discovered same bug is present in core opclasses. Attached patch fixes this issue interpreting nan as value greater than infinity like btree