Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin

2017-01-09 Thread Kuntal Ghosh
On Tue, Jan 10, 2017 at 2:52 AM, Alvaro Herrera wrote: > > Alvaro Herrera wrote: > > > If you examine the revmap in a replica after running the script below, > > you'd observe it's different than the one in the master. I confirmed > > that the proposed patch fixes the problem. > > Pushed. Thanks

Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin

2017-01-09 Thread Alvaro Herrera
Alvaro Herrera wrote: > If you examine the revmap in a replica after running the script below, > you'd observe it's different than the one in the master. I confirmed > that the proposed patch fixes the problem. Pushed. Thanks for the report! -- Álvaro Herrerahttps://www.2ndQua

Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin

2017-01-09 Thread Alvaro Herrera
Alvaro Herrera wrote: > Kuntal Ghosh wrote: > > Hi all, > > > > In brin_doupdate(line 290), REGBUF_STANDARD is used to register > > revmap buffer reference in WAL record. But, revmap buffer page doesn't > > have a standard page layout and it doesn't update pd_upper and > > pd_lower as well. > > H

Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin

2017-01-09 Thread Alvaro Herrera
Kuntal Ghosh wrote: > Hi all, > > In brin_doupdate(line 290), REGBUF_STANDARD is used to register > revmap buffer reference in WAL record. But, revmap buffer page doesn't > have a standard page layout and it doesn't update pd_upper and > pd_lower as well. Hmm. This bug should be causing WAL repl

Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin

2017-01-09 Thread Alvaro Herrera
Kuntal Ghosh wrote: > Added to next commitfest for tracking. I should've done it earlier. Yeah -- I hadn't noticed this thread until last week. I intend to apply this very soon. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Train

Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin

2017-01-07 Thread Kuntal Ghosh
Added to next commitfest for tracking. I should've done it earlier. -- Thanks & Regards, Kuntal Ghosh EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-h

Re: [HACKERS] Incorrect XLogRegisterBuffer flag for revmapbuf in brin

2016-11-09 Thread Michael Paquier
On Wed, Nov 9, 2016 at 9:33 PM, Kuntal Ghosh wrote: > In brin_doupdate(line 290), REGBUF_STANDARD is used to register > revmap buffer reference in WAL record. But, revmap buffer page doesn't > have a standard page layout and it doesn't update pd_upper and > pd_lower as well. > > Either we should r