Re: [HACKERS] Intermittent regression test failure from index-only scans patch

2011-10-11 Thread Magnus Hagander
On Sun, Oct 9, 2011 at 06:34, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Oct 8, 2011, at 11:04 AM, Tom Lane t...@sss.pgh.pa.us wrote: I'm inclined to fix this by changing the test to examine idx_tup_read not idx_tup_fetch.  Alternatively, we could have the

Re: [HACKERS] Intermittent regression test failure from index-only scans patch

2011-10-11 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Sun, Oct 9, 2011 at 06:34, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Should we have another counter for heap fetches avoided?  Seems like that could be useful to know. Hm.  I'm hesitant to add another

Re: [HACKERS] Intermittent regression test failure from index-only scans patch

2011-10-08 Thread Cédric Villemain
2011/10/8 Tom Lane t...@sss.pgh.pa.us: I notice that several members of the buildfarm have been consistently showing the same regression test failure since the index-only scans patch went in: *** /home/pgbuildfarm/workdir/HEAD/pgsql.27150/src/test/regress/expected/stats.out      Sat Oct  

Re: [HACKERS] Intermittent regression test failure from index-only scans patch

2011-10-08 Thread Tom Lane
=?ISO-8859-1?Q?C=E9dric_Villemain?= cedric.villemain.deb...@gmail.com writes: 2011/10/8 Tom Lane t...@sss.pgh.pa.us: The diff indicates that the idx_scan count advanced but idx_tup_fetch did not, which is not so surprising here because tenk2 hasn't been modified in some time.  If the

Re: [HACKERS] Intermittent regression test failure from index-only scans patch

2011-10-08 Thread Robert Haas
On Oct 8, 2011, at 11:04 AM, Tom Lane t...@sss.pgh.pa.us wrote: I'm inclined to fix this by changing the test to examine idx_tup_read not idx_tup_fetch. Alternatively, we could have the test force enable_indexonlyscan off. Thoughts? No preference. Should we have another counter for heap

Re: [HACKERS] Intermittent regression test failure from index-only scans patch

2011-10-08 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Oct 8, 2011, at 11:04 AM, Tom Lane t...@sss.pgh.pa.us wrote: I'm inclined to fix this by changing the test to examine idx_tup_read not idx_tup_fetch. Alternatively, we could have the test force enable_indexonlyscan off. Thoughts? No preference.