Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2011-06-16 Thread Pavel Stehule
2011/6/15 Pavel Stehule pavel.steh...@gmail.com: Hello I try to apply your patch, but it is finished with some failed hinks. Please, can you refresh your patch Regards Pavel [pavel@nemesis postgresql]$ patch -p1 pghba.patch patching file src/backend/libpq/hba.c Hunk #1 succeeded at

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2011-03-31 Thread Brendan Jurd
On 29 October 2010 09:59, Brendan Jurd dire...@gmail.com wrote: On 18 October 2010 01:19, Tom Lane t...@sss.pgh.pa.us wrote: Brendan Jurd dire...@gmail.com writes: On 17 October 2010 09:59, Tom Lane t...@sss.pgh.pa.us wrote: Good point.  Maybe the correct fix is to remember whether each token

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2011-02-27 Thread Bruce Momjian
Brendan Jurd wrote: On 26 February 2011 18:06, Bruce Momjian br...@momjian.us wrote: Any progress on this? I ended up doing most of the work, but never got around to finishing it off. Thanks for the reminder, though. I'll get that one ready and drop it onto the next CF. Added to

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2011-02-26 Thread Brendan Jurd
On 26 February 2011 18:06, Bruce Momjian br...@momjian.us wrote: Any progress on this? I ended up doing most of the work, but never got around to finishing it off. Thanks for the reminder, though. I'll get that one ready and drop it onto the next CF. Cheers, BJ -- Sent via pgsql-hackers

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2011-02-26 Thread Magnus Hagander
On Sat, Feb 26, 2011 at 10:57, Brendan Jurd dire...@gmail.com wrote: On 26 February 2011 18:06, Bruce Momjian br...@momjian.us wrote: Any progress on this? I ended up doing most of the work, but never got around to finishing it off.  Thanks for the reminder, though.  I'll get that one ready

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2011-02-25 Thread Bruce Momjian
Any progress on this? --- Brendan Jurd wrote: On 18 October 2010 01:19, Tom Lane t...@sss.pgh.pa.us wrote: Brendan Jurd dire...@gmail.com writes: On 17 October 2010 09:59, Tom Lane t...@sss.pgh.pa.us wrote: Good

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-28 Thread Brendan Jurd
On 18 October 2010 01:19, Tom Lane t...@sss.pgh.pa.us wrote: Brendan Jurd dire...@gmail.com writes: On 17 October 2010 09:59, Tom Lane t...@sss.pgh.pa.us wrote: Good point.  Maybe the correct fix is to remember whether each token was quoted or not, so that keyword detection can be done safely

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-17 Thread Tom Lane
Brendan Jurd dire...@gmail.com writes: On 17 October 2010 09:59, Tom Lane t...@sss.pgh.pa.us wrote: Good point.  Maybe the correct fix is to remember whether each token was quoted or not, so that keyword detection can be done safely after the initial lexing.  I still think that the current

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-16 Thread Brendan Jurd
On 13 October 2010 00:28, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Oct 9, 2010 at 11:13 AM, Brendan Jurd dire...@gmail.com wrote: I understand that 'replication' is a keyword as far as the database name is concerned, but I was surprised to find that it was treated as a keyword in the

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-16 Thread Brendan Jurd
On 17 October 2010 01:52, Brendan Jurd dire...@gmail.com wrote: Per the above discussion, I've prepared a patch to make keywords in pg_hba.conf field-specific. Try New and Improved This Message (tm), now with attachment! Cheers, BJ *** a/src/backend/libpq/hba.c --- b/src/backend/libpq/hba.c

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-16 Thread Alvaro Herrera
Excerpts from Brendan Jurd's message of sáb oct 16 11:53:31 -0300 2010: On 17 October 2010 01:52, Brendan Jurd dire...@gmail.com wrote: Per the above discussion, I've prepared a patch to make keywords in pg_hba.conf field-specific. Try New and Improved This Message (tm), now with

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-16 Thread Brendan Jurd
On 17 October 2010 02:27, Alvaro Herrera alvhe...@commandprompt.com wrote: Hmm.  Would it be possible to list keywords _applicable_ to each field, and have these passed down to next_token by the caller instead?  This seems backwards, but I'm not sure if the other way is really workable. Short

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-16 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Brendan Jurd's message of sáb oct 16 11:53:31 -0300 2010: Try New and Improved This Message (tm), now with attachment! Hmm. Would it be possible to list keywords _applicable_ to each field, and have these passed down to

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-16 Thread Tom Lane
Brendan Jurd dire...@gmail.com writes: Full answer: The problem is that pg_hba.conf doesn't have a fixed structure. Each line can be 4, 5 or 6 fields (not including the final 'options' field) long, and which of these structures apply to any given line isn't decided until parse_hba_line goes

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-16 Thread Brendan Jurd
On 17 October 2010 09:59, Tom Lane t...@sss.pgh.pa.us wrote: Brendan Jurd dire...@gmail.com writes: At the time that next_token gets called, we have no way of knowing which field is currently being tokenised, at least not without doing some serious rearrangement of hba.c, so that it tokenises

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-12 Thread Fujii Masao
On Sat, Oct 9, 2010 at 11:13 AM, Brendan Jurd dire...@gmail.com wrote: I understand that 'replication' is a keyword as far as the database name is concerned, but I was surprised to find that it was treated as a keyword in the username field also.  I had a look in src/backend/libpq/hba.c, and

Re: [HACKERS] Keywords in pg_hba.conf should be field-specific

2010-10-08 Thread Robert Haas
On Fri, Oct 8, 2010 at 10:13 PM, Brendan Jurd dire...@gmail.com wrote: One of the speedbumps I hit when setting up HS+SR was naming the user the slave would connect as for streaming replication.  At first I picked 'replication', which seemed quite natural to me (and I don't doubt will seem