Re: [HACKERS] Order of operations in SubPostmasterMain()

2016-09-29 Thread Andres Freund
On 2016-09-29 15:46:00 -0400, Tom Lane wrote: > I noticed that buildfarm member culicidae, which is running an > EXEC_BACKEND build on Linux, occasionally falls over like this: > > FATAL: could not reattach to shared memory (key=6280001, > addr=0x7fa9df845000): Invalid argument > > That's proba

Re: [HACKERS] Order of operations in SubPostmasterMain()

2016-09-29 Thread Tom Lane
Greg Stark writes: > On Thu, Sep 29, 2016 at 8:46 PM, Tom Lane wrote: >> We could probably refactor things enough so that we do pq_init() >> before PGSharedMemoryReAttach(). It would be a little bit ugly, >> and it would fractionally increase the chance of a reattach failure >> because pq_init()

Re: [HACKERS] Order of operations in SubPostmasterMain()

2016-09-29 Thread Greg Stark
On Thu, Sep 29, 2016 at 8:46 PM, Tom Lane wrote: > We could probably refactor things enough so that we do pq_init() > before PGSharedMemoryReAttach(). It would be a little bit ugly, > and it would fractionally increase the chance of a reattach failure > because pq_init() palloc's a few KB worth o