Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-12-22 Thread Robert Haas
On Mon, Dec 21, 2015 at 6:28 PM, David Rowley wrote: > According to grep -rE "appendStringInfoString\(.*\.data\);" . we have 13 > such matches. None of them seem to be in very performance critical places, > perhaps with the exception of xmlconcat(). > > Would you

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-12-21 Thread David Rowley
On 22 December 2015 at 01:58, Robert Haas wrote: > On Thu, Jul 2, 2015 at 6:08 AM, David Rowley > wrote: > >> I left out the changes like > >> > >>> - appendStringInfoString(, buf.data); > >>> +

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-12-21 Thread Pavel Stehule
2015-12-21 13:58 GMT+01:00 Robert Haas : > On Thu, Jul 2, 2015 at 6:08 AM, David Rowley > wrote: > >> I left out the changes like > >> > >>> - appendStringInfoString(, buf.data); > >>> + appendBinaryStringInfo(,

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-12-21 Thread Robert Haas
On Thu, Jul 2, 2015 at 6:08 AM, David Rowley wrote: >> I left out the changes like >> >>> - appendStringInfoString(, buf.data); >>> + appendBinaryStringInfo(, buf.data, buf.len); >> >> >> because they're not an improvement in readablity,

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-07-02 Thread Heikki Linnakangas
On 06/15/2015 03:56 AM, David Rowley wrote: On 29 May 2015 at 12:51, Peter Eisentraut pete...@gmx.net wrote: On 5/12/15 4:33 AM, David Rowley wrote: Shortly after I sent the previous patch I did a few more searches and also found some more things that are not quite right. Most of these are to

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-07-02 Thread David Rowley
On 2 July 2015 at 21:59, Heikki Linnakangas hlinn...@iki.fi wrote: Applied the straightforward parts. Thanks for committing. I left out the changes like - appendStringInfoString(collist, buf.data); + appendBinaryStringInfo(collist, buf.data, buf.len);

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-07-02 Thread Alvaro Herrera
David Rowley wrote: On 2 July 2015 at 21:59, Heikki Linnakangas hlinn...@iki.fi wrote: I left out the changes like - appendStringInfoString(collist, buf.data); + appendBinaryStringInfo(collist, buf.data, buf.len); because they're not an improvement in

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-06-14 Thread David Rowley
On 29 May 2015 at 12:51, Peter Eisentraut pete...@gmx.net wrote: On 5/12/15 4:33 AM, David Rowley wrote: Shortly after I sent the previous patch I did a few more searches and also found some more things that are not quite right. Most of these are to use the binary append method when the

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-05-28 Thread Peter Eisentraut
On 5/12/15 4:33 AM, David Rowley wrote: Shortly after I sent the previous patch I did a few more searches and also found some more things that are not quite right. Most of these are to use the binary append method when the length of the string is already known. For these cases it might be

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-05-12 Thread David Rowley
On 12 May 2015 at 12:57, Peter Eisentraut pete...@gmx.net wrote: On 4/11/15 6:25 AM, David Rowley wrote: I've attached a small patch which just fixes a few appendStringInfo* calls that are not quite doing things the way that it was intended. done Thank you for pushing. Shortly after I

Re: [HACKERS] Patch to improve a few appendStringInfo* calls

2015-05-11 Thread Peter Eisentraut
On 4/11/15 6:25 AM, David Rowley wrote: I've attached a small patch which just fixes a few appendStringInfo* calls that are not quite doing things the way that it was intended. done -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: