Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-09 Thread Tom Lane
Thomas Munro writes: > On Thu, Nov 9, 2017 at 6:27 PM, Tom Lane wrote: >> Is there really much interest in Bonjour support on non-macOS platforms? >> I hadn't heard that anybody but Apple was invested in it. > Not from me. My only interest

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Thomas Munro
On Thu, Nov 9, 2017 at 6:27 PM, Tom Lane wrote: > Thomas Munro writes: >> On Thu, Nov 9, 2017 at 5:03 PM, Tom Lane wrote: >>> Is the AC_SEARCH_LIBS configure call needed to make PG build with the >>> FreeBSD package? > >>

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Tom Lane
Thomas Munro writes: > On Thu, Nov 9, 2017 at 5:03 PM, Tom Lane wrote: >> Is the AC_SEARCH_LIBS configure call needed to make PG build with the >> FreeBSD package? > Yes. My take is that the commit was correct: the library is needed > for

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Thomas Munro
On Thu, Nov 9, 2017 at 5:03 PM, Tom Lane wrote: > Is the AC_SEARCH_LIBS configure call needed to make PG build with the > FreeBSD package? Yes. My take is that the commit was correct: the library is needed for --with-bonjour to work on non-macOS systems, and apparently it

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Tom Lane
Thomas Munro writes: > On Thu, Nov 9, 2017 at 1:39 PM, Tom Lane wrote: >> Hm, the library on F25 is also avahi's. Digging in the archives, I find >> this old thread reporting the same behavior: >>

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Thomas Munro
On Thu, Nov 9, 2017 at 1:39 PM, Tom Lane wrote: > Luke Lonergan writes: >> On 11/8/17, 3:00 PM, "Tom Lane" wrote: >>> BTW, when I try this on Fedora 25, it builds cleanly but the feature >>> doesn't seem to work --- I get this at

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Luke Lonergan
Hey Tom, On 11/8/17, 4:39 PM, "Tom Lane" wrote: So now I'm wondering if you know something the rest of us don't about how to configure the platform for bonjour to work. Nope – in fact, I hadn’t tried to use Bonjour on this instance, but had only enabled it thinking

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Tom Lane
Luke Lonergan writes: > On 11/8/17, 3:00 PM, "Tom Lane" wrote: >> BTW, when I try this on Fedora 25, it builds cleanly but the feature >> doesn't seem to work --- I get this at postmaster start: >> ... >> I wonder which libdns_sd you are using. >

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Luke Lonergan
# dpkg -S !$ dpkg -S /usr/lib/x86_64-linux-gnu/libdns_sd.so.1.0.0 libavahi-compat-libdnssd1:amd64: /usr/lib/x86_64-linux-gnu/libdns_sd.so.1.0.0 Also:   ii libavahi-compat-libdnssd1:amd640.6.32-1ubuntu1 amd64Avahi Apple Bonjour

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Luke Lonergan
Hi Tom – works for me on Linux (Ubuntu)… - Luke *** /home/llonergan/archive/configure.in2017-11-08 14:17:56.804891827 -0800 --- configure.in2017-11-08 14:15:58.961186149 -0800 *** *** 1293,1298 --- 1293,1299 if test

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Tom Lane
Luke Lonergan writes: > Hi Tom – works for me on Linux (Ubuntu)… BTW, when I try this on Fedora 25, it builds cleanly but the feature doesn't seem to work --- I get this at postmaster start: *** WARNING *** The program 'postgres' uses the Apple Bonjour compatibility layer

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Tom Lane
Luke Lonergan writes: > Hi Tom – works for me on Linux (Ubuntu)… > + AC_SEARCH_LIBS([DNSServiceRefSockFD],[dns_sd]) Pushed with an error message added. I also took the trouble to standardize the syntax of our various AC_SEARCH_LIBS calls --- they weren't very consistent

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Tom Lane
Thomas Munro writes: > On Thu, Nov 9, 2017 at 10:05 AM, Luke Lonergan wrote: >> + AC_CHECK_LIB(dns_sd, DNSServiceRefSockFD, [], [AC_MSG_ERROR([library >> 'dns_sd' is required for Bonjour])]) > It lives in libSystem.dylib (implicitly linked)

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

2017-11-08 Thread Thomas Munro
On Thu, Nov 9, 2017 at 10:05 AM, Luke Lonergan wrote: > if test "$with_bonjour" = yes ; then > > AC_CHECK_HEADER(dns_sd.h, [], [AC_MSG_ERROR([header file is > required for Bonjour])]) > > + AC_CHECK_LIB(dns_sd, DNSServiceRefSockFD, [], [AC_MSG_ERROR([library >