Re: [HACKERS] Please correct/improve wiki page about abbreviated keys bug

2016-03-31 Thread Peter Geoghegan
On Wed, Mar 30, 2016 at 6:23 PM, Josh berkus wrote: > Based on that concept, I wrote a query which is now on the wiki page. > Please fix it if it's not showing what we want it to show. Sorry, I got caught up with something last night. I did this this morning Pacific time. I've made a number of p

Re: [HACKERS] Please correct/improve wiki page about abbreviated keys bug

2016-03-30 Thread Peter Geoghegan
Okay. I'll look at it later today. -- Peter Geoghegan

Re: [HACKERS] Please correct/improve wiki page about abbreviated keys bug

2016-03-30 Thread Josh berkus
On 03/30/2016 02:47 PM, Josh berkus wrote: > On 03/29/2016 07:43 PM, Peter Geoghegan wrote: >> Do you think it would be okay if the SQL query to detect potentially >> affected indexes only considered the leading attribute? Since that's >> the only attribute that could use abbreviated keys, it ought

Re: [HACKERS] Please correct/improve wiki page about abbreviated keys bug

2016-03-30 Thread Josh berkus
On 03/29/2016 07:43 PM, Peter Geoghegan wrote: > On Tue, Mar 29, 2016 at 7:31 PM, Tom Lane wrote: >> A corrupt index could easily fail to detect uniqueness violations (because >> searches fail to find entries they should find). Not sure I believe that >> it would make false reports of a uniquenes

Re: [HACKERS] Please correct/improve wiki page about abbreviated keys bug

2016-03-29 Thread Tom Lane
Peter Geoghegan writes: > Do you think it would be okay if the SQL query to detect potentially > affected indexes only considered the leading attribute? Since that's > the only attribute that could use abbreviated keys, it ought to be > safe to not require users to REINDEX indexes that happen to h

Re: [HACKERS] Please correct/improve wiki page about abbreviated keys bug

2016-03-29 Thread Peter Geoghegan
On Tue, Mar 29, 2016 at 7:31 PM, Tom Lane wrote: > A corrupt index could easily fail to detect uniqueness violations (because > searches fail to find entries they should find). Not sure I believe that > it would make false reports of a uniqueness conflict that's not really > there. Sure. But loo

Re: [HACKERS] Please correct/improve wiki page about abbreviated keys bug

2016-03-29 Thread Tom Lane
Peter Geoghegan writes: > I made a pass over this, and changed some things. I noticed it said > something about incorrect unique violations on affected systems. Is > that really possible? A corrupt index could easily fail to detect uniqueness violations (because searches fail to find entries they

Re: [HACKERS] Please correct/improve wiki page about abbreviated keys bug

2016-03-29 Thread Peter Geoghegan
On Tue, Mar 29, 2016 at 5:31 PM, Josh berkus wrote: > For Thursday's release, I've added a wiki page to give users more > information about the strxfrm() issue, especially since we're going to > ask them to do a bunch of REINDEXing. I made a pass over this, and changed some things. I noticed it s