Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-05-18 Thread Ashutosh Bapat
On Fri, May 13, 2016 at 10:14 AM, Robert Haas wrote: > On Wed, Mar 23, 2016 at 12:53 PM, Robert Haas > wrote: > > On Wed, Mar 23, 2016 at 5:24 AM, Rajkumar Raghuwanshi > > wrote: > >> Thanks Ashutosh for the patch. I have apply and retested it, now not > getting > >> server crash. > > > > Thank

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-05-16 Thread Rajkumar Raghuwanshi
Thanks for the commit. I have tested it again. Not getting server crash now. Thanks & Regards, Rajkumar Raghuwanshi QMG, EnterpriseDB Corporation On Mon, May 16, 2016 at 9:38 PM, Robert Haas wrote: > On Fri, May 13, 2016 at 6:40 PM, Michael Paquier > wrote: > > On Fri, May 13, 2016 at 11:14 PM

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-05-16 Thread Robert Haas
On Fri, May 13, 2016 at 6:40 PM, Michael Paquier wrote: > On Fri, May 13, 2016 at 11:14 PM, Robert Haas wrote: >> So, barring objections, I intend to apply the attached fixup patch, >> which replaces Michael's logic with Ashutosh's logic and rewrites the >> comments such to be much more explicit.

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-05-13 Thread Michael Paquier
On Fri, May 13, 2016 at 11:14 PM, Robert Haas wrote: > So, barring objections, I intend to apply the attached fixup patch, > which replaces Michael's logic with Ashutosh's logic and rewrites the > comments such to be much more explicit. Re-oops. I didn't check what was committed to be honest. And

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-05-13 Thread Robert Haas
On Wed, Mar 23, 2016 at 12:53 PM, Robert Haas wrote: > On Wed, Mar 23, 2016 at 5:24 AM, Rajkumar Raghuwanshi > wrote: >> Thanks Ashutosh for the patch. I have apply and retested it, now not getting >> server crash. > > Thanks for the report and the testing. I have committed the patch. So it's b

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-03-24 Thread Ashutosh Bapat
> > Thanks for the report and the testing. I have committed the patch. > > Thanks. > Cool, I have refreshed the wiki page for open items accordingly. > Thanks. -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-03-23 Thread Michael Paquier
On Thu, Mar 24, 2016 at 1:53 AM, Robert Haas wrote: > On Wed, Mar 23, 2016 at 5:24 AM, Rajkumar Raghuwanshi > wrote: >> Thanks Ashutosh for the patch. I have apply and retested it, now not getting >> server crash. > > Thanks for the report and the testing. I have committed the patch. Cool, I ha

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-03-23 Thread Robert Haas
On Wed, Mar 23, 2016 at 5:24 AM, Rajkumar Raghuwanshi wrote: > Thanks Ashutosh for the patch. I have apply and retested it, now not getting > server crash. Thanks for the report and the testing. I have committed the patch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-03-23 Thread Michael Paquier
On Mon, Mar 21, 2016 at 11:32 PM, Ashutosh Bapat wrote: >> In get_useful_ecs_for_relation, it seems to me that this assertion >> should be removed and replaces by an actual check because even if >> right_ec and left_ec are initialized, we cannot be sure that ec_relids >> contains the relations spe

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-03-23 Thread Rajkumar Raghuwanshi
Thanks Ashutosh for the patch. I have apply and retested it, now not getting server crash. Thanks & Regards, Rajkumar Raghuwanshi QMG, EnterpriseDB Corporation On Mon, Mar 21, 2016 at 8:02 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > Thanks Michael for looking into this. > > >

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-03-21 Thread Ashutosh Bapat
Thanks Michael for looking into this. > In get_useful_ecs_for_relation, it seems to me that this assertion > should be removed and replaces by an actual check because even if > right_ec and left_ec are initialized, we cannot be sure that ec_relids > contains the relations specified: > /*

Re: [HACKERS] Postgres_fdw join pushdown - getting server crash in left outer join of three table

2016-03-20 Thread Michael Paquier
On Fri, Mar 18, 2016 at 7:22 PM, Rajkumar Raghuwanshi wrote: > Hi, > > I am testing postgres_fdw join pushdown feature for PostgreSQL 9.6 DB, and I > observed below issue. > > Observation: If do a left outer join on foreign tables more than two times. > It is causing the server crash. > > Added be