Re: [HACKERS] REASSIGN OWNED doesn't know how to deal with USER MAPPINGs

2015-12-11 Thread Alvaro Herrera
Jaime Casanova wrote:
> On 10 December 2015 at 13:04, Jaime Casanova
>  wrote:
> > Hi,
> >
> > We just notice $SUBJECT. Attached patch fixes it by ignoring USER
> > MAPPINGs in shdepReassignOwned() just like it happens with default
> > ACLs.

Yep, I had already posted this patch elsewhere, and I just pushed it.

> BTW, shouldn't we at least give a warning on those cases instead of
> asuming that the user will know that some objects were ignored?

I don't think so.  This kind of thing is supposed to silent when nothing
is to be done.

-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] REASSIGN OWNED doesn't know how to deal with USER MAPPINGs

2015-12-10 Thread Jaime Casanova
On 10 December 2015 at 13:04, Jaime Casanova
 wrote:
> Hi,
>
> We just notice $SUBJECT. Attached patch fixes it by ignoring USER
> MAPPINGs in shdepReassignOwned() just like it happens with default
> ACLs.
>

BTW, shouldn't we at least give a warning on those cases instead of
asuming that the user will know that some objects were ignored?

-- 
Jaime Casanova  www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers