Re: [HACKERS] Random crud left behind by aborted TAP tests

2015-12-05 Thread Tom Lane
Michael Paquier writes: > On Sat, Dec 5, 2015 at 1:59 AM, Tom Lane wrote: >> Let's just put the cruft in tmp_check/ and call it good. > +1. Having those folders with random names showing up when typing git > statue is annoying, so voilà. Looks good to me, so pushed. re

Re: [HACKERS] Random crud left behind by aborted TAP tests

2015-12-05 Thread Michael Paquier
On Sat, Dec 5, 2015 at 1:59 AM, Tom Lane wrote: > Let's just put the cruft in tmp_check/ and call it good. +1. Having those folders with random names showing up when typing git statue is annoying, so voilà. -- Michael 20151205_tap_tempdirs.patch Description: binary/octet-stream -- Sent via p

Re: [HACKERS] Random crud left behind by aborted TAP tests

2015-12-04 Thread Tom Lane
Alvaro Herrera writes: >> Hmm ... I would have supposed that this directory should have been >> removed by File::Temp's END block. Are END blocks abandoned completely >> when a signal is received? That seems pretty surprising. > Yes, they are. Quoth man perlmod: >An "END" code block i

Re: [HACKERS] Random crud left behind by aborted TAP tests

2015-12-04 Thread Alvaro Herrera
Alvaro Herrera wrote: > Tom Lane wrote: > > Yesterday I was fooling around with the TAP tests, and at least once > > I changed my mind and control-C'd out of a run. Today I find: > > > > [postgres@sss1 pgsql]$ git status > > On branch master > > Your branch is up-to-date with 'origin/master'. > >

Re: [HACKERS] Random crud left behind by aborted TAP tests

2015-12-04 Thread Alvaro Herrera
Tom Lane wrote: > Yesterday I was fooling around with the TAP tests, and at least once > I changed my mind and control-C'd out of a run. Today I find: > > [postgres@sss1 pgsql]$ git status > On branch master > Your branch is up-to-date with 'origin/master'. > > Untracked files: > (use "git add