Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.
Simon Riggs wrote: So we might have a pg_hba.conf that looks like this TYPE DATABASEUSER CIDR-ADDRESS METHOD host replication foo 192.168.0.5 md5 host replication foo 192.168.0.5 md5 Which looks pretty strange. I think we should change that, though if not we should at least document it. The default pg_hba.conf says: # Database and user names containing spaces, commas, quotes and other # special characters must be quoted. Quoting one of the keywords # all, sameuser, samerole or replication makes the name lose # its special character, and just match a database or username with # that name. but I don't see any mention of that in the docs. How about: *** client-auth.sgml24 Mar 2010 09:44:06 +0200 1.134 --- client-auth.sgml24 Mar 2010 13:21:16 +0200 *** *** 77,84 a set of records, one per line. Blank lines are ignored, as is any text after the literal#/literal comment character. A record is made up of a number of fields which are separated by spaces and/or tabs. !Fields can contain white space if the field value is quoted. Records !cannot be continued across lines. /para para --- 77,87 a set of records, one per line. Blank lines are ignored, as is any text after the literal#/literal comment character. A record is made up of a number of fields which are separated by spaces and/or tabs. !Fields can contain white space if the field value is quoted. !Quoting one of the keywords in database or username field (e.g all !or replication) makes the name lose its special character, and just !match a database or username with that name. Records cannot be !continued across lines. /para para That probably tips the balance towards having the alternate wording: LOG: replication connection authorized: user=foo +1 -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.
On Wed, Mar 24, 2010 at 8:22 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: but I don't see any mention of that in the docs. How about: *** client-auth.sgml 24 Mar 2010 09:44:06 +0200 1.134 --- client-auth.sgml 24 Mar 2010 13:21:16 +0200 *** *** 77,84 a set of records, one per line. Blank lines are ignored, as is any text after the literal#/literal comment character. A record is made up of a number of fields which are separated by spaces and/or tabs. ! Fields can contain white space if the field value is quoted. Records ! cannot be continued across lines. /para para --- 77,87 a set of records, one per line. Blank lines are ignored, as is any text after the literal#/literal comment character. A record is made up of a number of fields which are separated by spaces and/or tabs. ! Fields can contain white space if the field value is quoted. ! Quoting one of the keywords in database or username field (e.g all ! or replication) makes the name lose its special character, and just ! match a database or username with that name. Records cannot be ! continued across lines. /para +1 That probably tips the balance towards having the alternate wording: LOG: replication connection authorized: user=foo +1 +1 Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.
On Wed, 2010-03-24 at 20:30 +0900, Fujii Masao wrote: On Wed, Mar 24, 2010 at 8:22 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: but I don't see any mention of that in the docs. How about: +1 Yes, plus a mention in the rep docs. That probably tips the balance towards having the alternate wording: LOG: replication connection authorized: user=foo +1 +1 Will do. What's the word on when you guys will be finished with the open items list for SR? Feels like we're both using the other one as an excuse not to complete our remaining actions. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.
On Wed, Mar 24, 2010 at 8:52 PM, Simon Riggs si...@2ndquadrant.com wrote: What's the word on when you guys will be finished with the open items list for SR? Sorry, I'm not sure when. Now, I'm trying to address the open item Walreceiver is not interruptible on win32. It might take time to create the patch since I'm not familiar with tweaking Makefile or something. http://archives.postgresql.org/pgsql-hackers/2010-03/msg00413.php Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.
On 24/03/2010 6:29 PM, Simon Riggs wrote: So we are allowing a database to be called REPLICATION? Surely there are some significant problems in that case. How will access control to that database work in the pg_hba.conf? Surely it should be consistent with template0 and postgres: template1=# create database postgres; ERROR: database postgres already exists template1=# create database postgres; ERROR: database postgres already exists template1=# create database POSTGRES; CREATE DATABASE template1=# create database template0; ERROR: database template0 already exists template1=# create database template0; ERROR: database template0 already exists template1=# create database TEMPLATE0; CREATE DATABASE -- Craig Ringer -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
