Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Michael Paquier writes: > On Mon, Apr 18, 2016 at 12:31 PM, Peter Eisentraut wrote: >> I don't know if it's worth tracking this as an open item and thus >> kind-of release blocker if no one else has the problem. But I >> definitely still have it. My initial suspicion was that this had >> something to do with a partial upgrade to gcc 6 (not yet released), in >> other words a messed up system. But I was able to reproduce it in a >> freshly installed chroot. It only happens with various versions of gcc, >> but not with clang. So I'm going to have to keep digging. > gcc is moving slowly but surely to have 6.0 in a released state btw: > https://gcc.gnu.org/ml/gcc/2016-04/msg00103.html Given that it's apparently showing the results of asind as NULL, the theory that comes to mind is some sort of optimization issue affecting the output tuple's null-flags. I have no idea why only this test would be affected, though. Anyway, a good way to test that theory would be to see if the -O level affects it. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
On Mon, Apr 18, 2016 at 12:31 PM, Peter Eisentraut wrote: > I don't know if it's worth tracking this as an open item and thus > kind-of release blocker if no one else has the problem. But I > definitely still have it. My initial suspicion was that this had > something to do with a partial upgrade to gcc 6 (not yet released), in > other words a messed up system. But I was able to reproduce it in a > freshly installed chroot. It only happens with various versions of gcc, > but not with clang. So I'm going to have to keep digging. gcc is moving slowly but surely to have 6.0 in a released state btw: https://gcc.gnu.org/ml/gcc/2016-04/msg00103.html -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
On 04/15/2016 02:04 PM, Robert Haas wrote: > Peter, are you going to look into this further? This is on the open > items list, but there seems to be nothing that can be done about it by > anyone other than, maybe, you. I don't know if it's worth tracking this as an open item and thus kind-of release blocker if no one else has the problem. But I definitely still have it. My initial suspicion was that this had something to do with a partial upgrade to gcc 6 (not yet released), in other words a messed up system. But I was able to reproduce it in a freshly installed chroot. It only happens with various versions of gcc, but not with clang. So I'm going to have to keep digging. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
On Fri, Apr 8, 2016 at 5:48 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 01/22/2016 03:46 PM, Tom Lane wrote: >>> Add trigonometric functions that work in degrees. > >> I have a host here that is having regression test failures from this commit: > >> --- src/test/regress/expected/float8.out >> +++ src/test/regress/results/float8.out >> @@ -490,9 +490,9 @@ >> x | asind | acosd | atand >> --+---+---+--- >> -1 | -90 | 180 | -45 >> - -0.5 | -30 | 120 | >> + -0.5 | | 120 | >> 0 | 0 |90 | 0 >> - 0.5 |30 |60 | >> + 0.5 | |60 | >> 1 |90 | 0 |45 >> (5 rows) > > BTW ... looking closer at that, it appears to show asind(-0.5) and > asind(0.5) returning NULL. Which makes no sense at all, because > there is no provision in dasind() for returning a null, regardless > of the input value. > > So I'm pretty baffled. Maybe you could step through this and figure > out where it's going off the rails? Peter, are you going to look into this further? This is on the open items list, but there seems to be nothing that can be done about it by anyone other than, maybe, you. If you're not going to look into it, I think we should delete the open item. There's no point in tracking issues that aren't actionable. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Peter Eisentraut writes: > On 01/22/2016 03:46 PM, Tom Lane wrote: >> Add trigonometric functions that work in degrees. > I have a host here that is having regression test failures from this commit: > --- src/test/regress/expected/float8.out > +++ src/test/regress/results/float8.out > @@ -490,9 +490,9 @@ > x | asind | acosd | atand > --+---+---+--- > -1 | -90 | 180 | -45 > - -0.5 | -30 | 120 | > + -0.5 | | 120 | > 0 | 0 |90 | 0 > - 0.5 |30 |60 | > + 0.5 | |60 | > 1 |90 | 0 |45 > (5 rows) BTW ... looking closer at that, it appears to show asind(-0.5) and asind(0.5) returning NULL. Which makes no sense at all, because there is no provision in dasind() for returning a null, regardless of the input value. So I'm pretty baffled. Maybe you could step through this and figure out where it's going off the rails? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Peter Eisentraut writes: > On 04/04/2016 09:20 PM, Michael Paquier wrote: >> Likely an oversight not tracked by the buildfarm. What are you using here? > It should be a rather unspectactular Debian system. I have tried a > bunch of different compilers and optimization options, without success. > I'll keep looking. Perhaps it'd be worthwhile to check the behavior before and after each of the portability patches that followed on to e1bd684a3, and see if any of them change the behavior for you (and if so just how). That might give us a clue what's going on. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
On 04/04/2016 09:20 PM, Michael Paquier wrote: Likely an oversight not tracked by the buildfarm. What are you using here? It should be a rather unspectactular Debian system. I have tried a bunch of different compilers and optimization options, without success. I'll keep looking. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Michael Paquier writes: > On Tue, Apr 5, 2016 at 10:16 AM, Peter Eisentraut wrote: >> On 01/22/2016 03:46 PM, Tom Lane wrote: >>> Add trigonometric functions that work in degrees. >> I have a host here that is having regression test failures from this commit: > Likely an oversight not tracked by the buildfarm. What are you using here? Indeed. Also, I trust you're checking 00347575e or later, and not e1bd684a3 itself? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
On Tue, Apr 5, 2016 at 10:16 AM, Peter Eisentraut wrote: > On 01/22/2016 03:46 PM, Tom Lane wrote: >> >> Add trigonometric functions that work in degrees. >> >> The implementations go to some lengths to deliver exact results for values >> where an exact result can be expected, such as sind(30) = 0.5 exactly. > > I have a host here that is having regression test failures from this commit: > > --- src/test/regress/expected/float8.out > +++ src/test/regress/results/float8.out > @@ -490,9 +490,9 @@ >x | asind | acosd | atand > --+---+---+--- > -1 | -90 | 180 | -45 > - -0.5 | -30 | 120 | > + -0.5 | | 120 | > 0 | 0 |90 | 0 > - 0.5 |30 |60 | > + 0.5 | |60 | > 1 |90 | 0 |45 > (5 rows) > > Any ideas? Likely an oversight not tracked by the buildfarm. What are you using here? -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
