Re: [HACKERS] Re: [GENERAL] pg_basebackup error: replication slot "pg_basebackup_2194" already exists

2017-05-31 Thread Magnus Hagander
On Wed, May 31, 2017 at 8:18 PM, Andres Freund wrote: > On 2017-05-31 18:22:18 +0200, Magnus Hagander wrote: > > However, the client can't access the pid of the server as it is now, > > and its the client that has to create the name. > > I don't think that's actually true? Doesn't the wire proto

Re: [HACKERS] Re: [GENERAL] pg_basebackup error: replication slot "pg_basebackup_2194" already exists

2017-05-31 Thread Michael Paquier
On Wed, May 31, 2017 at 11:18 AM, Andres Freund wrote: > On 2017-05-31 18:22:18 +0200, Magnus Hagander wrote: >> However, the client can't access the pid of the server as it is now, >> and its the client that has to create the name. > > I don't think that's actually true? Doesn't the wire protoco

Re: [HACKERS] Re: [GENERAL] pg_basebackup error: replication slot "pg_basebackup_2194" already exists

2017-05-31 Thread Andres Freund
On 2017-05-31 18:22:18 +0200, Magnus Hagander wrote: > However, the client can't access the pid of the server as it is now, > and its the client that has to create the name. I don't think that's actually true? Doesn't the wire protocol always include the PID, which is then exposed with PQbackendP

Re: [HACKERS] Re: [GENERAL] pg_basebackup error: replication slot "pg_basebackup_2194" already exists

2017-05-31 Thread Michael Paquier
On Wed, May 31, 2017 at 9:22 AM, Magnus Hagander wrote: > Moving this one over to -hackers to discuss the fix, as this is clearly an > issue. > > Right now, pg_basebackup will use the pid of the *client* process to > generate it's ephemeral slot name. Per this report that seems like it can > defin