Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-24 Thread Tomasz Rybak
I'm merging all your emails for sake of easier discussion. I also cut all fragments that do not require response. W dniu 22.01.2016, pią o godzinie 11∶06 +0800, użytkownik Craig Ringer napisał: > > We might also think about changing name of plugin to something > > resembling

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-24 Thread Andres Freund
On 2016-01-18 21:47:27 +, Tomasz Rybak wrote: > We might also think about changing name of plugin to something resembling > "logical_streaming_decoder" or even "logical_streamer" FWIW, I find those proposals unconvincing. Not that pglogical_output is grand, but "streaming decoder" or

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-21 Thread Robert Haas
On Wed, Jan 20, 2016 at 8:04 PM, Craig Ringer wrote: > itself is an abbreviation of its self. I do not think this is true. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-21 Thread Robert Haas
On Wed, Jan 20, 2016 at 12:54 AM, Craig Ringer wrote: > The idea here is that we want downwards compatibility as far as possible and > maintainable but we can't really be upwards compatible for breaking protocol > revisions. So the output plugin's native protocol version is

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-21 Thread Craig Ringer
On 22 January 2016 at 06:13, Tomasz Rybak wrote: > + data stream. The output stream is designed to be compact and fast to > decode, > + and the plugin supports upstream filtering of data so that only the > required > + information is sent. > > plugin supports upstream

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-20 Thread Craig Ringer
On 21 January 2016 at 06:23, Tomasz Rybak wrote: > > I reviewed more files: Thanks. Can you try to put more whitespace between items? It can be hard to follow at the moment. > pglogical_proto_native.c > > + pq_sendbyte(out, 'N'); /* column name

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-20 Thread Tomasz Rybak
W dniu 20.01.2016, śro o godzinie 13∶54 +0800, użytkownik Craig Ringer napisał: > On 20 January 2016 at 06:23, Tomasz Rybak > wrote: > > The following review has been posted through the commitfest > > application: > > > Thanks! >   > >   > > + /* Protocol capabilities */ >

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-19 Thread Craig Ringer
On 20 January 2016 at 06:23, Tomasz Rybak wrote: > The following review has been posted through the commitfest application: > Thanks! > > + /* Protocol capabilities */ > + #define PGLOGICAL_PROTO_VERSION_NUM 1 > + #define PGLOGICAL_PROTO_MIN_VERSION_NUM 1 > Is this

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-04 Thread Shulgin, Oleksandr
On Sun, Jan 3, 2016 at 7:21 PM, Tomasz Rybak wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: not tested > Spec compliant: not tested > Documentation:

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-04 Thread Alvaro Herrera
Shulgin, Oleksandr wrote: > A make from an external build dir fails on install, suggested fix: > > install: all > $(MKDIR_P) '$(DESTDIR)$(includedir)'/pglogical_output > - $(INSTALL_DATA) pglogical_output/hooks.h > '$(DESTDIR)$(includedir)'/pglogical_output > + $(INSTALL_DATA) >