Re: [HACKERS] Regression testing for psql

2010-05-29 Thread Selena Deckelmann
On Wed, May 26, 2010 at 6:25 PM, Stephen Frost sfr...@snowman.net wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: There might be some value in psql backslash command tests that are designed to depend on just one or a few tables (or other appropriate objects). Updated, much much smaller, patch

Re: [HACKERS] Regression testing for psql

2010-05-26 Thread Peter Eisentraut
On tis, 2010-05-25 at 06:23 -0400, Stephen Frost wrote: * Robert Haas (robertmh...@gmail.com) wrote: Of course, if people want to suggest tests that just shouldn't be included, I can go through and strip things out. Well... I'm a little reluctant to believe that we should have 3.3M of

Re: [HACKERS] Regression testing for psql

2010-05-26 Thread Stephen Frost
* Peter Eisentraut (pete...@gmx.net) wrote: Maybe pg_regress is not the right framework to test that sort of thing. Perhaps, but if not, then what? And how can we avoid writing a bunch of new code that would then need to be checked itself..? Thanks, Stephen

Re: [HACKERS] Regression testing for psql

2010-05-26 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: Then, too, there's the fact that many of these tests fail on my machine because my username is not sfrost, I've updated the patch to address this, it's again at: http://snowman.net/~sfrost/psql-regress-help.patch If the size is still an issue, I

Re: [HACKERS] Regression testing for psql

2010-05-26 Thread alvherre
Excerpts from Stephen Frost's message of mié may 26 15:19:59 -0400 2010: * Robert Haas (robertmh...@gmail.com) wrote: Then, too, there's the fact that many of these tests fail on my machine because my username is not sfrost, I've updated the patch to address this, it's again at:

Re: [HACKERS] Regression testing for psql

2010-05-26 Thread Stephen Frost
* alvherre (alvhe...@commandprompt.com) wrote: Excerpts from Stephen Frost's message of mié may 26 15:19:59 -0400 2010: * Robert Haas (robertmh...@gmail.com) wrote: Then, too, there's the fact that many of these tests fail on my machine because my username is not sfrost, I've

Re: [HACKERS] Regression testing for psql

2010-05-26 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: * alvherre (alvhe...@commandprompt.com) wrote: (And if we want something like this, I think we should not have a single huge file for the complete test, but a set of smaller files. I'd even put the bunch in src/bin/psql/regress rather than the main

Re: [HACKERS] Regression testing for psql

2010-05-26 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: There might be some value in psql backslash command tests that are designed to depend on just one or a few tables (or other appropriate objects). Dumping large fractions of the catalogs will just be a net loss. Fair enough, I can certainly do that

Re: [HACKERS] Regression testing for psql

2010-05-26 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: There might be some value in psql backslash command tests that are designed to depend on just one or a few tables (or other appropriate objects). Updated, much much smaller, patch attached. Also available, again, at

Re: [HACKERS] Regression testing for psql

2010-05-25 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: Of course, if people want to suggest tests that just shouldn't be included, I can go through and strip things out. Well... I'm a little reluctant to believe that we should have 3.3M of tests for the entire backend and 5M of tests just for psql.

Re: [HACKERS] Regression testing for psql

2010-05-24 Thread Stephen Frost
* Stephen Frost (sfr...@snowman.net) wrote: Add regression testing for psql backslash commands This patch adds rather extensive regression testing of the psql backslash commands. Hopefully this will minimize issues such as the one which cropped up recently with \h

Re: [HACKERS] Regression testing for psql

2010-05-24 Thread Robert Haas
On Mon, May 24, 2010 at 10:51 PM, Stephen Frost sfr...@snowman.net wrote: * Stephen Frost (sfr...@snowman.net) wrote:     Add regression testing for psql backslash commands     This patch adds rather extensive regression testing     of the psql backslash commands.  Hopefully this will