Re: [HACKERS] Removing link-time cross-module refs in contrib

2017-01-28 Thread Tom Lane
Noah Misch writes: > ... adding $(pkglibdir) to rpath is obsolete, now that this ceased to link to > hstore explicitly. OK... > For consistency with longstanding src/pl/plpython practice, $(python_libspec) > should always have an accompanying $(python_additional_libs). This

Re: [HACKERS] Removing link-time cross-module refs in contrib

2017-01-27 Thread Noah Misch
On Mon, Oct 03, 2016 at 12:29:18PM -0400, Tom Lane wrote: > Pursuant to Andres' suggestion in > https://www.postgresql.org/message-id/20161002223927.57xns3arkdg4h...@alap3.anarazel.de > attached is a draft patch that gets rid of link-time references > from hstore_plpython to both hstore and

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Andres Freund
On 2016-10-03 15:40:12 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2016-10-03 14:49:20 -0400, Tom Lane wrote: > >> ... ignoring unresolved symbols in shlibs is the default > >> on Linux, and while you can make it throw errors, that just leads to > >> errors for all

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Tom Lane
Andres Freund writes: > On 2016-10-03 14:49:20 -0400, Tom Lane wrote: >> ... ignoring unresolved symbols in shlibs is the default >> on Linux, and while you can make it throw errors, that just leads to >> errors for all the references into the core backend. Not very helpful.

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Andres Freund
On 2016-10-03 14:49:20 -0400, Tom Lane wrote: > > On 2016-10-03 12:29:18 -0400, Tom Lane wrote: > >> The patch seems pretty successful in terms of being noninvasive to > >> the code. I think the major objection to it would be that we no > >> longer have any direct compiler-verified connection

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Tom Lane
Andres Freund writes: > On 2016-10-03 12:29:18 -0400, Tom Lane wrote: >> The patch seems pretty successful in terms of being noninvasive to >> the code. I think the major objection to it would be that we no >> longer have any direct compiler-verified connection between the >>

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Andres Freund
Hi, On 2016-10-03 12:29:18 -0400, Tom Lane wrote: > The patch seems pretty successful in terms of being noninvasive to > the code. I think the major objection to it would be that we no > longer have any direct compiler-verified connection between the > signatures of the called functions in