Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-06-26 Thread Fujii Masao
On Wed, Mar 28, 2012 at 10:08 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Mar 28, 2012 at 12:30 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Fujii Masao's message of mar mar 27 06:40:34 -0300 2012: Anyway, should I add this patch into the next CF? Or is anyone

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-27 Thread Fujii Masao
On Mon, Mar 26, 2012 at 11:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Mar 26, 2012 at 2:50 AM, Magnus Hagander mag...@hagander.net wrote: s/segment/file/g? We're already using file to mean something different *internally*, don't we? And since

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-27 Thread Alvaro Herrera
Excerpts from Fujii Masao's message of mar mar 27 06:40:34 -0300 2012: Anyway, should I add this patch into the next CF? Or is anyone planning to commit the patch for 9.2? I think the correct thing to do here is add to next CF, and if some committer has enough interest in getting it quickly

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-27 Thread Fujii Masao
On Wed, Mar 28, 2012 at 12:30 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Fujii Masao's message of mar mar 27 06:40:34 -0300 2012: Anyway, should I add this patch into the next CF? Or is anyone planning to commit the patch for 9.2? I think the correct thing to do here

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-26 Thread Magnus Hagander
On Fri, Mar 23, 2012 at 18:05, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Mar 24, 2012 at 1:49 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Mar 23, 2012 at 12:42 PM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Mar 23, 2012 at 9:41 PM, Robert Haas robertmh...@gmail.com wrote:

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-26 Thread Robert Haas
On Mon, Mar 26, 2012 at 2:50 AM, Magnus Hagander mag...@hagander.net wrote: s/segment/file/g? Yep, file might be more intuitive for a user than segment. Attached is the file version of the patch. We're already using file to mean something different *internally*, don't we? And since

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-26 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Mar 26, 2012 at 2:50 AM, Magnus Hagander mag...@hagander.net wrote: s/segment/file/g? We're already using file to mean something different *internally*, don't we? And since pg_controldata shows fairly internal information, I'm not sure this

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-23 Thread Magnus Hagander
On Fri, Mar 23, 2012 at 05:06, Fujii Masao masao.fu...@gmail.com wrote: Hi, I'd like to propose to change pg_controldata so that it reports the name of WAL file containing the latest checkpoint's REDO record, as follows:    $ pg_controldata $PGDATA    ...    Latest checkpoint's REDO

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-23 Thread Fujii Masao
On Fri, Mar 23, 2012 at 2:06 PM, Jaime Casanova ja...@2ndquadrant.com wrote: On Thu, Mar 22, 2012 at 11:06 PM, Fujii Masao masao.fu...@gmail.com wrote: We can use pg_xlogfile_name function to calculate that, but it cannot be executed in the standby. Another problem is that pg_xlogfile_name

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-23 Thread Magnus Hagander
On Fri, Mar 23, 2012 at 10:51, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Mar 23, 2012 at 2:06 PM, Jaime Casanova ja...@2ndquadrant.com wrote: On Thu, Mar 22, 2012 at 11:06 PM, Fujii Masao masao.fu...@gmail.com wrote: We can use pg_xlogfile_name function to calculate that, but it cannot

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-23 Thread Fujii Masao
On Fri, Mar 23, 2012 at 5:56 PM, Magnus Hagander mag...@hagander.net wrote: Might it be a good idea to put it on it's own row instead of changing the format of an existing row, in order not to break scripts and programs that are parsing the previous output? Good idea! What row name should we

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-23 Thread Robert Haas
On Fri, Mar 23, 2012 at 6:13 AM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Mar 23, 2012 at 5:56 PM, Magnus Hagander mag...@hagander.net wrote: Might it be a good idea to put it on it's own row instead of changing the format of an existing row, in order not to break scripts and programs

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-23 Thread Fujii Masao
On Fri, Mar 23, 2012 at 9:41 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Mar 23, 2012 at 6:13 AM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Mar 23, 2012 at 5:56 PM, Magnus Hagander mag...@hagander.net wrote: Might it be a good idea to put it on it's own row instead of changing

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-23 Thread Robert Haas
On Fri, Mar 23, 2012 at 12:42 PM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Mar 23, 2012 at 9:41 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Mar 23, 2012 at 6:13 AM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Mar 23, 2012 at 5:56 PM, Magnus Hagander mag...@hagander.net

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-23 Thread Fujii Masao
On Sat, Mar 24, 2012 at 1:49 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Mar 23, 2012 at 12:42 PM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Mar 23, 2012 at 9:41 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Mar 23, 2012 at 6:13 AM, Fujii Masao masao.fu...@gmail.com

Re: [HACKERS] Reporting WAL file containing checkpoint's REDO record in pg_controldata's result

2012-03-22 Thread Jaime Casanova
On Thu, Mar 22, 2012 at 11:06 PM, Fujii Masao masao.fu...@gmail.com wrote: We can use pg_xlogfile_name function to calculate that, but it cannot be executed in the standby. Another problem is that pg_xlogfile_name always uses current timeline for the calculation, so if the reported timeline