Re: [HACKERS] Retire src/backend/port/dynloader/linux.c ?

2016-12-19 Thread Andres Freund 
On 2016-12-18 22:19:36 -0500, Tom Lane wrote:
> Andres Freund  writes:
> > Shouldn't we just remove that code?
> 
> What for?

I every now and then end up looking at it for a few minutes, and wonder
what the hell dld is, just to see that it's old stuff.

> It's maintenance-free ... hasn't been touched since 2004.
> While I agree with you that it's *probably* dead code, it's hard to
> see much upside from removing it.
> 
> If we want to get into arguing whether code is dead or not, there's
> an awful lot of potentially removable stuff in the tree, but I doubt
> it's worth the trouble to figure out what's really dead.

Well, it's sometimes annoying to hit the code while looking around
that's actually dead. But I don't feel that strongly.

Greetings,

Andres Freund


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Retire src/backend/port/dynloader/linux.c ?

2016-12-18 Thread Peter Eisentraut 
On 12/18/16 10:19 PM, Tom Lane wrote:
> Andres Freund  writes:
>> Shouldn't we just remove that code?
> 
> What for?  It's maintenance-free ... hasn't been touched since 2004.
> While I agree with you that it's *probably* dead code, it's hard to
> see much upside from removing it.
> 
> If we want to get into arguing whether code is dead or not, there's
> an awful lot of potentially removable stuff in the tree, but I doubt
> it's worth the trouble to figure out what's really dead.

If someone wants to dive into it, I think you could probably remove most
or all of the prehistoric pre-dlopen code for *bsd and darwin as well.

The hpux and win32 code could be moved to libpgport, and then we could
just call dlopen() etc. directly and remove this whole subdirectory.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Retire src/backend/port/dynloader/linux.c ?

2016-12-18 Thread Tom Lane 
Andres Freund  writes:
> Shouldn't we just remove that code?

What for?  It's maintenance-free ... hasn't been touched since 2004.
While I agree with you that it's *probably* dead code, it's hard to
see much upside from removing it.

If we want to get into arguing whether code is dead or not, there's
an awful lot of potentially removable stuff in the tree, but I doubt
it's worth the trouble to figure out what's really dead.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers