Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-02-01 Thread Michael Paquier
On Mon, Feb 1, 2016 at 10:22 PM, Fujii Masao wrote: > Pushed. Thanks! > OK. And attached is the promised patch for ALTER FUNCTION. -- Michael diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index 5f27120..3369a3d 100644 ---

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-02-01 Thread Fujii Masao
On Mon, Feb 1, 2016 at 9:23 PM, Michael Paquier wrote: > On Mon, Feb 1, 2016 at 9:15 PM, Fujii Masao wrote: >> If we do that, we also should change the tab-completion for SET command >> so that "=" is suggested. But I'm afraid that which might decrease that >>

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-02-01 Thread Michael Paquier
On Mon, Feb 1, 2016 at 9:15 PM, Fujii Masao wrote: > If we do that, we also should change the tab-completion for SET command > so that "=" is suggested. But I'm afraid that which might decrease that > tab-completion. > > Imagine the case of "SET work_mem ". If "TO" and "=" are suggested, > we need

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-02-01 Thread Fujii Masao
On Mon, Feb 1, 2016 at 3:14 PM, Michael Paquier wrote: > On Mon, Feb 1, 2016 at 1:21 PM, Fujii Masao wrote: >> On Fri, Jan 29, 2016 at 1:02 PM, Michael Paquier >> wrote: >>> On Fri, Jan 29, 2016 at 11:53 AM, Fujii

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-01-31 Thread Michael Paquier
On Mon, Feb 1, 2016 at 1:21 PM, Fujii Masao wrote: > On Fri, Jan 29, 2016 at 1:02 PM, Michael Paquier > wrote: >> On Fri, Jan 29, 2016 at 11:53 AM, Fujii Masao wrote: >>> I removed the above and added the following for

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-01-31 Thread Fujii Masao
On Fri, Jan 29, 2016 at 1:02 PM, Michael Paquier wrote: > On Fri, Jan 29, 2016 at 11:53 AM, Fujii Masao wrote: >> I removed the above and added the following for that case. >> >> +/* Complete ALTER DATABASE|FUNCTION|ROLE|USER ... SET */ >> +

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-01-28 Thread Michael Paquier
On Thu, Jan 28, 2016 at 9:32 PM, Fujii Masao wrote: > I found that the following tab-completions for SET/RESET which > worked properly before doesn't work properly now in the master. > > 1. ALTER SYSTEM SET|RESET lists nothing. > 2. ALTER DATABASE xxx SET lists nothing. >

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-01-28 Thread Fujii Masao
On Thu, Jan 28, 2016 at 10:50 PM, Masahiko Sawada wrote: > On Thu, Jan 28, 2016 at 10:15 PM, Michael Paquier > wrote: >> On Thu, Jan 28, 2016 at 9:32 PM, Fujii Masao wrote: >>> I found that the following tab-completions

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-01-28 Thread Fujii Masao
On Thu, Jan 28, 2016 at 10:15 PM, Michael Paquier wrote: > On Thu, Jan 28, 2016 at 9:32 PM, Fujii Masao wrote: >> I found that the following tab-completions for SET/RESET which >> worked properly before doesn't work properly now in the master. >>

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-01-28 Thread Michael Paquier
On Fri, Jan 29, 2016 at 11:53 AM, Fujii Masao wrote: > I removed the above and added the following for that case. > > +/* Complete ALTER DATABASE|FUNCTION|ROLE|USER ... SET */ > +else if (Matches2("ALTER", "DATABASE|FUNCTION|ROLE|USER") && > +

Re: [HACKERS] Several problems in tab-completions for SET/RESET

2016-01-28 Thread Masahiko Sawada
On Thu, Jan 28, 2016 at 10:15 PM, Michael Paquier wrote: > On Thu, Jan 28, 2016 at 9:32 PM, Fujii Masao wrote: >> I found that the following tab-completions for SET/RESET which >> worked properly before doesn't work properly now in the master. >>