Re: [HACKERS] Simplifying timezone support

2003-03-02 Thread Ross J. Reedstrom
On Fri, Feb 21, 2003 at 08:39:12PM -0600, Ross J. Reedstrom wrote: > > Every other validly formatted TZ variable that returns GMT should be > caught be the datetktbl check. > > I'll play with it this weekend, see how hard it is to make it work. O.K., the weekend's over, And I've created two diff

Re: [HACKERS] Simplifying timezone support

2003-03-02 Thread Ross J. Reedstrom
According to my sent folder, this went out Monday afternoon, but I haven't seen it yet, so I'm resending to the list only, without the attached patch. I'll send the patch over to patches. Any comment on the behavior, specifically, the heuristic for deciding tzset() failed, and the proposed order

Re: [HACKERS] Simplifying timezone support

2003-02-28 Thread Ross J. Reedstrom
On Fri, Feb 21, 2003 at 06:15:31PM -0500, Tom Lane wrote: > "Ross J. Reedstrom" <[EMAIL PROTECTED]> writes: > > I'm worried about cases like "Africa/Benin" for places that just happen > to be on the prime meridian, but don't call their time GMT or UTC. > Looking at a globe, it also seems possible

Re: [HACKERS] Simplifying timezone support

2003-02-28 Thread Ross J. Reedstrom
On Fri, Feb 21, 2003 at 05:45:53PM -0600, Ross J. Reedstrom wrote: > On Fri, Feb 21, 2003 at 06:15:31PM -0500, Tom Lane wrote: > > "Ross J. Reedstrom" <[EMAIL PROTECTED]> writes: > > > > > I'm worried about cases like "Africa/Benin" for places that just happen > > to be on the prime meridian, but

Re: [HACKERS] Simplifying timezone support

2003-02-28 Thread Ross J. Reedstrom
On Thu, Feb 20, 2003 at 04:19:21PM -0500, Tom Lane wrote: > "Ross J. Reedstrom" <[EMAIL PROTECTED]> writes: > > On Thu, Feb 20, 2003 at 03:21:09PM -0500, Tom Lane wrote: > >> Provide a portable way of getting libc to tell us whether it likes TZ, > >> and I'll be glad to fix this. > > > Dang that l

Re: [HACKERS] Simplifying timezone support

2003-02-21 Thread Tom Lane
"Ross J. Reedstrom" <[EMAIL PROTECTED]> writes: > If the time zone came back UNKOWN, we go ahead and see if tzset() can > interpret it. Criteria for failure: if the timezone offset came back 0, > and the reported tzname[0] is the same as the string that we passed in. If > it does, we fire a NOTICE

Re: [HACKERS] Simplifying timezone support

2003-02-21 Thread Ross J. Reedstrom
On Thu, Feb 20, 2003 at 03:21:09PM -0500, Tom Lane wrote: > "Ross J. Reedstrom" <[EMAIL PROTECTED]> writes: > > question about pgsql's time zone parsers. It appears there's at least > > two, since SET TIME ZONE accepts strings like 'US/Eastern', while general > > timestamp parsing doesn't: > > The

Re: [HACKERS] Simplifying timezone support

2003-02-20 Thread Tom Lane
"Ross J. Reedstrom" <[EMAIL PROTECTED]> writes: > On Thu, Feb 20, 2003 at 03:21:09PM -0500, Tom Lane wrote: >> Provide a portable way of getting libc to tell us whether it likes TZ, >> and I'll be glad to fix this. > Dang that lovely word 'portable'. However, given your proposed change, > perhaps

Re: [HACKERS] Simplifying timezone support

2003-02-20 Thread Tom Lane
"Ross J. Reedstrom" <[EMAIL PROTECTED]> writes: > question about pgsql's time zone parsers. It appears there's at least > two, since SET TIME ZONE accepts strings like 'US/Eastern', while general > timestamp parsing doesn't: The TIME ZONE string is fed to libc (via TZ environment variable); the ot

Re: [HACKERS] Simplifying timezone support

2003-02-20 Thread Ross J. Reedstrom
On Wed, Feb 19, 2003 at 10:35:58PM -0500, Tom Lane wrote: > Any objections? Not to your suggestion per se, but looking at the bug report raises a question about pgsql's time zone parsers. It appears there's at least two, since SET TIME ZONE accepts strings like 'US/Eastern', while general timest