Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-28 Thread Robert Haas
On Sun, Apr 27, 2014 at 1:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: ... and not, in particular, parse analysis or rewrite time? I think breaking those out would be a good idea. Especially rewrite time. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-28 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sun, Apr 27, 2014 at 1:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: ... and not, in particular, parse analysis or rewrite time? I think breaking those out would be a good idea. Especially rewrite time. Rewrite time seems generally negligible in

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-28 Thread Robert Haas
On Mon, Apr 28, 2014 at 11:36 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Apr 27, 2014 at 1:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: ... and not, in particular, parse analysis or rewrite time? I think breaking those out would be a good idea.

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-27 Thread Andreas Karlsson
On 04/27/2014 07:07 PM, Tom Lane wrote: Rewrite timing could easily be captured by EXPLAIN since that call is done within ExplainQuery(). Parse analysis isn't, but we could imagine having transformExplainStmt() time the operation and stick the result into a new field in struct ExplainStmt. I'm

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-27 Thread Tom Lane
Andreas Karlsson andr...@proxel.se writes: On 04/27/2014 07:07 PM, Tom Lane wrote: Rewrite timing could easily be captured by EXPLAIN since that call is done within ExplainQuery(). Parse analysis isn't, but we could imagine having transformExplainStmt() time the operation and stick the

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-27 Thread David G Johnston
Tom Lane-2 wrote Or we could add them into just the first planning-time printout, though that might also be misleading. If you are going to show a number for these steps, which seems like a good idea, then this seems like a reasonable option in the face of this situation. Basically two

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-27 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: I'd been a bit suspicious of the recent patch to add $SUBJECT without the other pre-execution components, but it just now occurred to me that there's at least one reason why this might be a significant omission: any delay caused by waiting to acquire

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-27 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: * Tom Lane (t...@sss.pgh.pa.us) wrote: I'd been a bit suspicious of the recent patch to add $SUBJECT without the other pre-execution components, but it just now occurred to me that there's at least one reason why this might be a significant omission:

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-27 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost sfr...@snowman.net writes: * Tom Lane (t...@sss.pgh.pa.us) wrote: I'd been a bit suspicious of the recent patch to add $SUBJECT without the other pre-execution components, but it just now occurred to me that there's at least one reason

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-27 Thread Josh Berkus
Tom, I'd been a bit suspicious of the recent patch to add $SUBJECT without the other pre-execution components, but it just now occurred to me that there's at least one reason why this might be a significant omission: any delay caused by waiting to acquire locks on the query's tables will be

Re: [HACKERS] So why is EXPLAIN printing only *plan* time?

2014-04-27 Thread Rajeev rastogi
On 27 April 2014 22:38, Tom Lane Wrote: ... and not, in particular, parse analysis or rewrite time? I'd been a bit suspicious of the recent patch to add $SUBJECT without the other pre-execution components, but it just now occurred to me that there's at least one reason why this might be a