On Fri, Nov 6, 2015 at 12:35 AM, Kyotaro HORIGUCHI
wrote:
> Hello, I tried to look on this as far as I can referring to
> numeric.c..
Thank you for the review, Horiguchi-san.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your sub
On Fri, Nov 6, 2015 at 9:19 AM, Robert Haas wrote:
> This is a good catch, so I pushed a fix.
Thanks for your help.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Nov 6, 2015 at 3:35 AM, Kyotaro HORIGUCHI
wrote:
> Hello, I tried to look on this as far as I can referring to
> numeric.c..
Oops, I didn't see this review before committing.
> 6. uuid_abbrev_convert()
>
> > memcpy((char *) &res, authoritative->data, sizeof(Datum));
>
> memcpy's protot
On Thu, Nov 5, 2015 at 7:10 PM, Peter Geoghegan wrote:
> On Thu, Oct 8, 2015 at 5:27 PM, Peter Geoghegan wrote:
>> This is more or less lifted from numeric_abbrev_convert_var(). Perhaps
>> you should change it there too. The extra set of parenthesis are
>> removed in the attached patch. The patch
Hello, I tried to look on this as far as I can referring to
numeric.c..
1. Patch application
This patch applies on the current master cleanly. And looks to
be work as expected.
2. uuid.c
pg_bswap.h is included under hash.h so it is not needed to be
included but I don't object if you in
On Thu, Oct 8, 2015 at 5:27 PM, Peter Geoghegan wrote:
> This is more or less lifted from numeric_abbrev_convert_var(). Perhaps
> you should change it there too. The extra set of parenthesis are
> removed in the attached patch. The patch also mechanically updates
> things to be consistent with the
On Tue, Oct 6, 2015 at 1:15 PM, Robert Haas wrote:
> +tmp = ((uint32) res ^ (uint32) ((uint64) res >> 32));
>
> The outer set of parentheses here seems pretty worthless. Perhaps one
> of the parentheses at the end of the statement should be moved to just
> after "res". That seems like it
On Sun, Oct 4, 2015 at 2:21 AM, Peter Geoghegan wrote:
> Attached is SortSupport for UUID type patch. This accelerates all UUID
> related sort-intense operations, making them about twice as fast with
> millions of tuples. I know that Heroku has plenty of tables used by
> various applications with
