Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-11-01 Thread Peter Eisentraut
On 10/13/14 3:16 PM, Bruce Momjian wrote: > Where are we on this? I think we discovered that the pros and cons of the different options are not as clear-cut, and it's better to leave the default as is until additional features make one option a clear winner. -- Sent via pgsql-hackers mailing l

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-10-13 Thread Bruce Momjian
On Fri, Aug 29, 2014 at 10:37:15PM +0200, Magnus Hagander wrote: > On Fri, Aug 29, 2014 at 10:34 PM, Peter Eisentraut wrote: > > On 8/27/14 2:55 AM, Magnus Hagander wrote: > >> I think the easy way of doing that is to just create an xlog.tar file. > >> Since we already create "base.tar" and possib

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-29 Thread Magnus Hagander
On Fri, Aug 29, 2014 at 10:34 PM, Peter Eisentraut wrote: > On 8/27/14 2:55 AM, Magnus Hagander wrote: >> I think the easy way of doing that is to just create an xlog.tar file. >> Since we already create "base.tar" and possibly n*, >> adding one more file shouldn't be a big problem, and would make

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-29 Thread Peter Eisentraut
On 8/27/14 2:55 AM, Magnus Hagander wrote: > I think the easy way of doing that is to just create an xlog.tar file. > Since we already create "base.tar" and possibly n*, > adding one more file shouldn't be a big problem, and would make such > an implementation much easier. Would be trivial to do .t

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-28 Thread Robert Haas
On Wed, Aug 27, 2014 at 2:55 AM, Magnus Hagander wrote: > On Wed, Aug 27, 2014 at 5:16 AM, Fujii Masao wrote: >> On Wed, Aug 27, 2014 at 6:16 AM, Magnus Hagander wrote: >>> On Tue, Aug 26, 2014 at 10:46 PM, Andres Freund >>> wrote: On 2014-08-26 16:41:44 -0400, Peter Eisentraut wrote: >>>

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Magnus Hagander
On Wed, Aug 27, 2014 at 5:16 AM, Fujii Masao wrote: > On Wed, Aug 27, 2014 at 6:16 AM, Magnus Hagander wrote: >> On Tue, Aug 26, 2014 at 10:46 PM, Andres Freund >> wrote: >>> On 2014-08-26 16:41:44 -0400, Peter Eisentraut wrote: On 8/26/14 12:40 PM, Magnus Hagander wrote: > I think th

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Fujii Masao
On Wed, Aug 27, 2014 at 6:16 AM, Magnus Hagander wrote: > On Tue, Aug 26, 2014 at 10:46 PM, Andres Freund > wrote: >> On 2014-08-26 16:41:44 -0400, Peter Eisentraut wrote: >>> On 8/26/14 12:40 PM, Magnus Hagander wrote: >>> > I think the first reason is gone now, and the risk/damage of the two >

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Magnus Hagander
On Tue, Aug 26, 2014 at 10:46 PM, Andres Freund wrote: > On 2014-08-26 16:41:44 -0400, Peter Eisentraut wrote: >> On 8/26/14 12:40 PM, Magnus Hagander wrote: >> > I think the first reason is gone now, and the risk/damage of the two >> > connections is probably smaller than running out of WAL. -x i

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Andres Freund
On 2014-08-26 16:41:44 -0400, Peter Eisentraut wrote: > On 8/26/14 12:40 PM, Magnus Hagander wrote: > > I think the first reason is gone now, and the risk/damage of the two > > connections is probably smaller than running out of WAL. -x is a good > > default for smaller systems, but -X is a safer o

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Peter Eisentraut
On 8/26/14 12:40 PM, Magnus Hagander wrote: > I think the first reason is gone now, and the risk/damage of the two > connections is probably smaller than running out of WAL. -x is a good > default for smaller systems, but -X is a safer one for bigger ones. So > I agree that changing the default mod

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Magnus Hagander
On Tue, Aug 26, 2014 at 6:51 PM, Andres Freund wrote: > On 2014-08-26 18:40:27 +0200, Magnus Hagander wrote: >> On Mon, Aug 25, 2014 at 1:35 PM, Andres Freund >> wrote: >> > Hi, >> > >> > currently pg_basebackup uses fetch mode when only -x is specified - >> > which imo isn't a very good thing t

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Andres Freund
On 2014-08-26 18:40:27 +0200, Magnus Hagander wrote: > On Mon, Aug 25, 2014 at 1:35 PM, Andres Freund wrote: > > Hi, > > > > currently pg_basebackup uses fetch mode when only -x is specified - > > which imo isn't a very good thing to use due to the increased risk of > > not fetching everything. >

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Magnus Hagander
On Mon, Aug 25, 2014 at 1:35 PM, Andres Freund wrote: > Hi, > > currently pg_basebackup uses fetch mode when only -x is specified - > which imo isn't a very good thing to use due to the increased risk of > not fetching everything. > How about switching to stream mode for 9.5+? I think the origina

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Oskari Saarenmaa
On 25/08/14 14:35, Andres Freund wrote: currently pg_basebackup uses fetch mode when only -x is specified - which imo isn't a very good thing to use due to the increased risk of not fetching everything. How about switching to stream mode for 9.5+? +1. I was just wondering why it's not the defa