Re: [HACKERS] Tabs or Spaces

2007-01-05 Thread Jim Nasby

On Jan 4, 2007, at 7:54 PM, Simon Riggs wrote:

On Thu, 2007-01-04 at 21:41 -0300, Alvaro Herrera wrote:

Simon Riggs wrote:

S'OK, just thought it was funny I'd been doing it backwards all this
time: Actively been replacing tabs with spaces. :-)


That explains why your patches always seemed to be so weird to me


LOL


spacing-wise :-)


Nobody ever said... laughs/rolls eyes/sighs


I just figured you were using British tabs instead of American ones. ;P
--
Jim Nasby[EMAIL PROTECTED]
EnterpriseDB  http://enterprisedb.com  512.569.9461 (cell)



---(end of broadcast)---
TIP 4: Have you searched our list archives?

  http://archives.postgresql.org


Re: [HACKERS] Tabs or Spaces

2007-01-05 Thread Bruce Momjian
Simon Riggs wrote:
> On Thu, 2007-01-04 at 16:01 -0500, Bruce Momjian wrote:
> > Tom Lane wrote:
> > > "Simon Riggs" <[EMAIL PROTECTED]> writes:
> > > > Minor request for clarification:
> > > > I read in the Developer's FAQ that tabs should be interpreted as 4
> > > > spaces. ...and also that pgindent replaces tabs as spaces.
> > > 
> > > No, it does the opposite (or I would hope so anyway).
> > 
> > Sorry, the mistake was in a reference to entab.  It now reads:
> > 
> > entab   converts spaces to tabs, used by pgindent
> 
> S'OK, just thought it was funny I'd been doing it backwards all this
> time: Actively been replacing tabs with spaces. :-)

It was a little more complex because entab does conversion to/from tabs,
but pgindent uses it in the "to tabs" mode.

-- 
  Bruce Momjian   [EMAIL PROTECTED]
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org


Re: [HACKERS] Tabs or Spaces

2007-01-04 Thread Simon Riggs
On Thu, 2007-01-04 at 21:41 -0300, Alvaro Herrera wrote:
> Simon Riggs wrote:
> > S'OK, just thought it was funny I'd been doing it backwards all this
> > time: Actively been replacing tabs with spaces. :-)
> 
> That explains why your patches always seemed to be so weird to me

LOL

> spacing-wise :-)

Nobody ever said... laughs/rolls eyes/sighs

-- 
  Simon Riggs 
  EnterpriseDB   http://www.enterprisedb.com



---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq


Re: [HACKERS] Tabs or Spaces

2007-01-04 Thread Alvaro Herrera
Simon Riggs wrote:
> On Thu, 2007-01-04 at 16:01 -0500, Bruce Momjian wrote:
> > Tom Lane wrote:
> > > "Simon Riggs" <[EMAIL PROTECTED]> writes:
> > > > Minor request for clarification:
> > > > I read in the Developer's FAQ that tabs should be interpreted as 4
> > > > spaces. ...and also that pgindent replaces tabs as spaces.
> > > 
> > > No, it does the opposite (or I would hope so anyway).
> > 
> > Sorry, the mistake was in a reference to entab.  It now reads:
> > 
> > entab   converts spaces to tabs, used by pgindent
> 
> S'OK, just thought it was funny I'd been doing it backwards all this
> time: Actively been replacing tabs with spaces. :-)

That explains why your patches always seemed to be so weird to me
spacing-wise :-)

-- 
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

---(end of broadcast)---
TIP 6: explain analyze is your friend


Re: [HACKERS] Tabs or Spaces

2007-01-04 Thread Simon Riggs
On Thu, 2007-01-04 at 16:01 -0500, Bruce Momjian wrote:
> Tom Lane wrote:
> > "Simon Riggs" <[EMAIL PROTECTED]> writes:
> > > Minor request for clarification:
> > > I read in the Developer's FAQ that tabs should be interpreted as 4
> > > spaces. ...and also that pgindent replaces tabs as spaces.
> > 
> > No, it does the opposite (or I would hope so anyway).
> 
> Sorry, the mistake was in a reference to entab.  It now reads:
> 
> entab   converts spaces to tabs, used by pgindent

S'OK, just thought it was funny I'd been doing it backwards all this
time: Actively been replacing tabs with spaces. :-)

-- 
  Simon Riggs 
  EnterpriseDB   http://www.enterprisedb.com



---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq


Re: [HACKERS] Tabs or Spaces

2007-01-04 Thread Bruce Momjian
Tom Lane wrote:
> "Simon Riggs" <[EMAIL PROTECTED]> writes:
> > Minor request for clarification:
> > I read in the Developer's FAQ that tabs should be interpreted as 4
> > spaces. ...and also that pgindent replaces tabs as spaces.
> 
> No, it does the opposite (or I would hope so anyway).

Sorry, the mistake was in a reference to entab.  It now reads:

entab   converts spaces to tabs, used by pgindent

-- 
  Bruce Momjian   [EMAIL PROTECTED]
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate


Re: [HACKERS] Tabs or Spaces

2007-01-04 Thread Bruce Momjian
Andrew Dunstan wrote:
> Tom Lane wrote:
> > "Simon Riggs" <[EMAIL PROTECTED]> writes:
> >   
> >> Minor request for clarification:
> >> I read in the Developer's FAQ that tabs should be interpreted as 4
> >> spaces. ...and also that pgindent replaces tabs as spaces.
> >> 
> >
> > No, it does the opposite (or I would hope so anyway).
> >
> >   
> 
> Sure looks that way in the code. In fact it detabifies and then 
> retabifies, from what I can see.
> 
> cheers
> 
> andrew
> 
> ---(end of broadcast)---
> TIP 2: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian   [EMAIL PROTECTED]
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq


Re: [HACKERS] Tabs or Spaces

2007-01-04 Thread Andrew Dunstan

Tom Lane wrote:

"Simon Riggs" <[EMAIL PROTECTED]> writes:
  

Minor request for clarification:
I read in the Developer's FAQ that tabs should be interpreted as 4
spaces. ...and also that pgindent replaces tabs as spaces.



No, it does the opposite (or I would hope so anyway).

  


Sure looks that way in the code. In fact it detabifies and then 
retabifies, from what I can see.


cheers

andrew

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster


Re: [HACKERS] Tabs or Spaces

2007-01-04 Thread Tom Lane
"Simon Riggs" <[EMAIL PROTECTED]> writes:
> Minor request for clarification:
> I read in the Developer's FAQ that tabs should be interpreted as 4
> spaces. ...and also that pgindent replaces tabs as spaces.

No, it does the opposite (or I would hope so anyway).

regards, tom lane

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly