Re: [HACKERS] Time to change pg_regress diffs to unified by default?

2017-04-06 Thread Tom Lane
Peter Eisentraut writes: > I think one problem is that diff -u is not as portable as diff -c. For > example, the HP-UX 11 man page of diff doesn't list it. FWIW, I can confirm that HPUX 10.20's diff hasn't got it. That would not affect gaur/pademelon, if we

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

2017-04-06 Thread Noah Misch
On Thu, Apr 06, 2017 at 07:01:32PM -0400, Tom Lane wrote: > Andres Freund writes: > > I personally, and I know of a bunch of other regular contributors, find > > context diffs very hard to read. Besides general dislike, for things > > like regression test output context diffs

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

2017-04-06 Thread David Rowley
On 7 April 2017 at 10:31, Andres Freund wrote: > Hi, > > I personally, and I know of a bunch of other regular contributors, find > context diffs very hard to read. Besides general dislike, for things > like regression test output context diffs are just not well suited. > E.g.

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

2017-04-06 Thread Andrew Dunstan
On 04/06/2017 09:17 PM, Peter Eisentraut wrote: > On 4/6/17 18:31, Andres Freund wrote: >> I personally have PG_REGRESS_DIFF_OPTS set to -dU10, but that doesn't >> help much analyzing buildfarm output. >> >> Therefore I propose changing the defaults in pg_regress.c. > I think one problem is that

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

2017-04-06 Thread Peter Eisentraut
On 4/6/17 18:31, Andres Freund wrote: > I personally have PG_REGRESS_DIFF_OPTS set to -dU10, but that doesn't > help much analyzing buildfarm output. > > Therefore I propose changing the defaults in pg_regress.c. I think one problem is that diff -u is not as portable as diff -c. For example,

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

2017-04-06 Thread Tom Lane
Andres Freund writes: > I personally, and I know of a bunch of other regular contributors, find > context diffs very hard to read. Besides general dislike, for things > like regression test output context diffs are just not well suited. Personally, I disagree completely.

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

2017-04-06 Thread Andrew Dunstan
On 04/06/2017 06:31 PM, Andres Freund wrote: > Hi, > > I personally, and I know of a bunch of other regular contributors, find > context diffs very hard to read. Besides general dislike, for things > like regression test output context diffs are just not well suited. > E.g. in >

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

2017-04-06 Thread Thomas Munro
On Fri, Apr 7, 2017 at 10:31 AM, Andres Freund wrote: > Hi, > > I personally, and I know of a bunch of other regular contributors, find > context diffs very hard to read. Besides general dislike, for things > like regression test output context diffs are just not well suited.