Re: [HACKERS] Trivial heap_finish_speculative() error message inaccuracy

On 2015-11-18 23:50:30 +0100, Andres Freund wrote: > Let's rather rip those function names out. Unless somebody protests I'm > going to do so in 9.5/master. Done. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Trivial heap_finish_speculative() error message inaccuracy

On 2015-11-03 19:14:44 -0800, Peter Geoghegan wrote: > On Tue, Nov 3, 2015 at 7:10 PM, Tom Lane wrote: > > This seems like a fine teaching moment in which to point out our > > longstanding error message style guideline that says not to put > > names of C functions into error

Re: [HACKERS] Trivial heap_finish_speculative() error message inaccuracy

Peter Geoghegan writes: > While auditing the access method code associated with ON CONFLICT DO > UPDATE's speculative insertion infrastructure, I noticed an > inaccuracy. > Attached patch fixes the trivial inaccuracy in a defensive elog() > call. Quite simply, this call site

Re: [HACKERS] Trivial heap_finish_speculative() error message inaccuracy

On Tue, Nov 3, 2015 at 7:10 PM, Tom Lane wrote: > This seems like a fine teaching moment in which to point out our > longstanding error message style guideline that says not to put > names of C functions into error messages in the first place. I don't ordinarily do that, of