Re: [HACKERS] units in postgresql.conf comments

2014-01-11 Thread Bruce Momjian
On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: I think these sort of entries don't make much sense: #wal_sender_timeout = 60s # in milliseconds; 0 disables I think we should remove units from the comments when it's clear from the name or the default value that time

Re: [HACKERS] units in postgresql.conf comments

2014-01-11 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: I think these sort of entries don't make much sense: #wal_sender_timeout = 60s # in milliseconds; 0 disables I think we should remove units from the comments when it's clear from

Re: [HACKERS] units in postgresql.conf comments

2014-01-11 Thread Josh Berkus
On 01/11/2014 11:06 AM, Bruce Momjian wrote: On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: I think these sort of entries don't make much sense: #wal_sender_timeout = 60s # in milliseconds; 0 disables I think we should remove units from the comments when it's clear

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Heikki Linnakangas
On 30.05.2013 06:43, Bruce Momjian wrote: On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: I think these sort of entries don't make much sense: #wal_sender_timeout = 60s # in milliseconds; 0 disables I think we should remove units from the comments when it's clear from

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Joshua D. Drake
On 05/30/2013 12:01 AM, Heikki Linnakangas wrote: We could make it mandatory to specify the unit in the value. Ie. throw an error on wal_sender_timeout = 50: ERROR: unit required for option wal_sender_timeout HINT: Valid units for this parameter are ms, s, min, h, and d. Then you wouldn't

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Magnus Hagander
On Thu, May 30, 2013 at 3:52 AM, Joshua D. Drake j...@commandprompt.com wrote: On 05/30/2013 12:01 AM, Heikki Linnakangas wrote: We could make it mandatory to specify the unit in the value. Ie. throw an error on wal_sender_timeout = 50: ERROR: unit required for option wal_sender_timeout

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Joshua D. Drake
On 05/30/2013 12:55 AM, Magnus Hagander wrote: I like this idea with one addition. We should have a default unit for each. For wal_sender_timeout seconds makes sense, but for checkpoint_timeout minutes makes sense (for example). This sounds like a good way to make things even more confusing.

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Heikki Linnakangas
On 30.05.2013 10:52, Joshua D. Drake wrote: On 05/30/2013 12:01 AM, Heikki Linnakangas wrote: We could make it mandatory to specify the unit in the value. Ie. throw an error on wal_sender_timeout = 50: ERROR: unit required for option wal_sender_timeout HINT: Valid units for this parameter are

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Joshua D. Drake
On 05/30/2013 01:14 AM, Heikki Linnakangas wrote: On 30.05.2013 10:52, Joshua D. Drake wrote: On 05/30/2013 12:01 AM, Heikki Linnakangas wrote: We could make it mandatory to specify the unit in the value. Ie. throw an error on wal_sender_timeout = 50: ERROR: unit required for option

Re: [HACKERS] units in postgresql.conf comments

2013-05-29 Thread Bruce Momjian
On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: I think these sort of entries don't make much sense: #wal_sender_timeout = 60s # in milliseconds; 0 disables I think we should remove units from the comments when it's clear from the name or the default value that time

Re: [HACKERS] Units in postgresql.conf -- How to report?

2006-07-25 Thread Albe Laurenz
Peter Eisentraut wrote: So assuming we allowed units in postgresql.conf, how would you report them with SHOW? 1. The way they were set (hard) 2. Without units (not user-friendly) 3. Always in base units (seconds or bytes) 4. The largest unit that gives an integer (4) seems the

Re: [HACKERS] Units in postgresql.conf -- How to report?

2006-07-25 Thread Jim C. Nasby
On Tue, Jul 25, 2006 at 08:48:34AM +0200, Albe Laurenz wrote: Peter Eisentraut wrote: So assuming we allowed units in postgresql.conf, how would you report them with SHOW? 1. The way they were set (hard) 2. Without units (not user-friendly) 3. Always in base units (seconds or

Re: [HACKERS] Units in postgresql.conf -- How to report?

2006-07-25 Thread Peter Eisentraut
Jim C. Nasby wrote: On Tue, Jul 25, 2006 at 08:48:34AM +0200, Albe Laurenz wrote: Peter Eisentraut wrote: So assuming we allowed units in postgresql.conf, how would you report them with SHOW? 1. The way they were set (hard) 2. Without units (not user-friendly) 3. Always

Re: [HACKERS] Units in postgresql.conf -- How to report?

2006-07-24 Thread David Fetter
On Mon, Jul 24, 2006 at 11:13:53PM +0200, Peter Eisentraut wrote: So assuming we allowed units in postgresql.conf, how would you report them with SHOW? 1. The way they were set (hard) 2. Without units (not user-friendly) 3. Always in base units (seconds or bytes) 4. The largest unit

Re: [HACKERS] Units in postgresql.conf

2006-07-21 Thread korry
Time units is easy: 1h = 60min = 3600s = 360ms We don't need anything larger than seconds at the moment. Except for log_rotation_age perhaps? -- Korry

Re: [HACKERS] Units in postgresql.conf

2006-07-21 Thread Josh Berkus
Gavin, Peter, I would imagine that Peter intends to handle backward compatibility by processing values without explicit units in the units assumed pre 8.2. Aha, I misunderstood. -- Josh Berkus PostgreSQL @ Sun San Francisco ---(end of

Re: [HACKERS] Units in postgresql.conf

2006-07-21 Thread Robert Treat
On Thursday 20 July 2006 18:16, Ron Mayer wrote: Peter Eisentraut wrote: I think it would be useful to allow units to be added to these settings, for example... shared_buffers = 512MB which is a bit cumbersome to calculate right now (you'd need = 65536). I haven't thought yet how to

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Jonah H. Harris
On 7/20/06, Peter Eisentraut [EMAIL PROTECTED] wrote: I think it would be useful to allow units to be added to these settings, for example shared_buffers = 1000kB checkpoint_warning = 30s This would also allow shared_buffers = 512MB which is a bit cumbersome to calculate right now (you'd

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Gavin Sherry
On Thu, 20 Jul 2006, Peter Eisentraut wrote: One frequent source of confusion are the different units that the parameters in postgresql.conf use. shared_buffers is in 8 kB, work_mem is in 1 kB; bgwriter_delay is in milliseconds, checkpoint_warning is in seconds. Obviously, we can't change

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Marko Kreen
On 7/20/06, Peter Eisentraut [EMAIL PROTECTED] wrote: One frequent source of confusion are the different units that the parameters in postgresql.conf use. shared_buffers is in 8 kB, work_mem is in 1 kB; bgwriter_delay is in milliseconds, checkpoint_warning is in seconds. Obviously, we can't

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Joe Conway
Peter Eisentraut wrote: One frequent source of confusion are the different units that the parameters in postgresql.conf use. shared_buffers is in 8 kB, work_mem is in 1 kB; bgwriter_delay is in milliseconds, checkpoint_warning is in seconds. Obviously, we can't change that without

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Darcy Buskermolen
On Thursday 20 July 2006 05:04, Jonah H. Harris wrote: On 7/20/06, Peter Eisentraut [EMAIL PROTECTED] wrote: I think it would be useful to allow units to be added to these settings, for example shared_buffers = 1000kB checkpoint_warning = 30s This would also allow shared_buffers

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Josh Berkus
Peter, One frequent source of confusion are the different units that the parameters in postgresql.conf use. shared_buffers is in 8 kB, work_mem is in 1 kB; bgwriter_delay is in milliseconds, checkpoint_warning is in seconds. Obviously, we can't change that without inconveniencing a lot of

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Peter Eisentraut
Zdenek Kotala wrote: Time units is easy: 1h = 60min = 3600s = 360ms We don't need anything larger than seconds at the moment. What kind of unit prefix will we use for memory? PostgreSQL has always used 1 kB = 1024 B. 1) will be unit required? No. What will be default unit for value

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Peter Eisentraut
Josh Berkus wrote: Well, it's on my TODO list for 8.2 to write a simple postgresql.conf conversion utility in Perl. If you wanted to make a change like that, it would make finishing that mandatory. I don't understand how that is related. Or what a conversion utility would be for that

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Peter Eisentraut
Josh Berkus wrote: Well, the main issue with changing the units of the PostgreSQL.conf file from a user perspective is that the numbers from you 8.0/8.1 conf file would no longer work. No one is intending to do any such change. -- Peter Eisentraut http://developer.postgresql.org/~petere/

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Josh Berkus
Peter, I don't understand how that is related. Or what a conversion utility would be for that matter. Well, the main issue with changing the units of the PostgreSQL.conf file from a user perspective is that the numbers from you 8.0/8.1 conf file would no longer work. A little conversion

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread David Fetter
On Thu, Jul 20, 2006 at 01:49:36PM +0200, Peter Eisentraut wrote: One frequent source of confusion are the different units that the parameters in postgresql.conf use. shared_buffers is in 8 kB, work_mem is in 1 kB; bgwriter_delay is in milliseconds, checkpoint_warning is in seconds.

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Zdenek Kotala
Peter Eisentraut wrote: One frequent source of confusion are the different units that the parameters in postgresql.conf use. shared_buffers is in 8 kB, work_mem is in 1 kB; bgwriter_delay is in milliseconds, checkpoint_warning is in seconds. Obviously, we can't change that without

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Zdenek Kotala
Peter Eisentraut wrote: Zdenek Kotala wrote: Time units is easy: 1h = 60min = 3600s = 360ms We don't need anything larger than seconds at the moment. What kind of unit prefix will we use for memory? PostgreSQL has always used 1 kB = 1024 B. 1) will be unit required? No. What will

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Ron Mayer
Peter Eisentraut wrote: I think it would be useful to allow units to be added to these settings, for example... shared_buffers = 512MB which is a bit cumbersome to calculate right now (you'd need = 65536). I haven't thought yet how to parse or implement this, but would people find this

Re: [HACKERS] Units in postgresql.conf

2006-07-20 Thread Gavin Sherry
On Thu, 20 Jul 2006, Josh Berkus wrote: Peter, I don't understand how that is related. Or what a conversion utility would be for that matter. Well, the main issue with changing the units of the PostgreSQL.conf file from a user perspective is that the numbers from you 8.0/8.1 conf file