Re: [HACKERS] Use of access(X_OK) check in pg_upgrade

2011-05-18 Thread Magnus Hagander
On Wed, May 18, 2011 at 11:41, Bruce Momjian br...@momjian.us wrote: I broke the Win32 build members by using access(X_OK) in pg_upgrade.  I have a fix for this but looking at pg_upgrade's exec.c, I see for Win32:            if ((buf.st_mode S_IXUSR) == 0) I am confused why Windows

Re: [HACKERS] Use of access(X_OK) check in pg_upgrade

2011-05-18 Thread Bruce Momjian
Bruce Momjian wrote: I broke the Win32 build members by using access(X_OK) in pg_upgrade. I have a fix for this but looking at pg_upgrade's exec.c, I see for Win32: if ((buf.st_mode S_IXUSR) == 0) I am confused why Windows supports S_IXUSR but not X_OK. I have applied the

Re: [HACKERS] Use of access(X_OK) check in pg_upgrade

2011-05-18 Thread Bruce Momjian
Magnus Hagander wrote: On Wed, May 18, 2011 at 11:41, Bruce Momjian br...@momjian.us wrote: I broke the Win32 build members by using access(X_OK) in pg_upgrade. ?I have a fix for this but looking at pg_upgrade's exec.c, I see for Win32: ? ? ? ? ? ?if ((buf.st_mode S_IXUSR) == 0) I

Re: [HACKERS] Use of access(X_OK) check in pg_upgrade

2011-05-18 Thread Magnus Hagander
On Wed, May 18, 2011 at 12:16, Bruce Momjian br...@momjian.us wrote: Magnus Hagander wrote: On Wed, May 18, 2011 at 11:41, Bruce Momjian br...@momjian.us wrote: I broke the Win32 build members by using access(X_OK) in pg_upgrade. ?I have a fix for this but looking at pg_upgrade's exec.c, I