Re: [HACKERS] WAL replay should fdatasync() segments?

2014-01-22 Thread Fujii Masao
On Thu, Jan 23, 2014 at 1:21 AM, Andres Freund and...@2ndquadrant.com wrote: Hi, Currently, XLogInsert(), XLogFlush() or XLogBackgroundFlush() will write() data before fdatasync()ing them (duh, kinda obvious). But I think given the current recovery code that leaves a window where we can get

Re: [HACKERS] WAL replay should fdatasync() segments?

2014-01-22 Thread Andres Freund
On 2014-01-23 02:05:48 +0900, Fujii Masao wrote: On Thu, Jan 23, 2014 at 1:21 AM, Andres Freund and...@2ndquadrant.com wrote: Hi, Currently, XLogInsert(), XLogFlush() or XLogBackgroundFlush() will write() data before fdatasync()ing them (duh, kinda obvious). But I think given the

Re: [HACKERS] WAL replay should fdatasync() segments?

2014-01-22 Thread Fujii Masao
On Thu, Jan 23, 2014 at 2:08 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-01-23 02:05:48 +0900, Fujii Masao wrote: On Thu, Jan 23, 2014 at 1:21 AM, Andres Freund and...@2ndquadrant.com wrote: Hi, Currently, XLogInsert(), XLogFlush() or XLogBackgroundFlush() will write() data