Attached is the patch as submitted for commitfest.
Please note, I am not adverse to adding an additional --Include-path
directive if that avoids backwards-compatibility problems. However the
patch is complex enough I would really prefer review on the rest of it to
start first. This doesn't strik
On 10/30/17 6:36 AM, Michael Paquier wrote:
> On Mon, Oct 30, 2017 at 10:15 AM, Chris Travers
>>
>> How does rep mgr or other programs using pg_rewind know what to exclude?
>
> Good question. Answers could come from folks such as David Steele
> (pgBackRest) or Marco (barman) whom I am attaching in
On Mon, Oct 30, 2017 at 11:36 AM, Michael Paquier wrote:
> On Mon, Oct 30, 2017 at 10:15 AM, Chris Travers
> wrote:
> > This also brings up a fairly major concern more generally about control
> by
> > the way. A lot of cases where pg_rewind is called, the user doesn't
> > necessarily have much
On Mon, Oct 30, 2017 at 10:15 AM, Chris Travers
wrote:
> This also brings up a fairly major concern more generally about control by
> the way. A lot of cases where pg_rewind is called, the user doesn't
> necessarily have much control on how it is called. Moreover in many of
> these cases, the us
On Mon, Oct 30, 2017 at 10:57 AM, Michael Paquier wrote:
> On Mon, Oct 30, 2017 at 9:43 AM, Chris Travers
> wrote:
> > Are there any cases right now where you have features added by
> extensions that write to directories which are required for a rewind?
>
> In some of the stuff I maintain, I act
On Mon, Oct 30, 2017 at 9:43 AM, Chris Travers wrote:
> Are there any cases right now where you have features added by extensions
> that write to directories which are required for a rewind?
In some of the stuff I maintain, I actually have one case now of a
configuration file included with inclu
First, thanks for your thoughts on this, and I am interested in probing
them more.
On Mon, Oct 30, 2017 at 9:04 AM, Michael Paquier
wrote:
> On Sat, Oct 28, 2017 at 4:22 AM, Chris Travers
> wrote:
> > The Solution:
> > The solution is a whitelist of directories specified which are the only
> on
On Sat, Oct 28, 2017 at 4:22 AM, Chris Travers wrote:
> The Solution:
> The solution is a whitelist of directories specified which are the only ones
> which are synchronised. The relevant part of this patch is:
>
> +/* List of directories to synchronize:
> + * base data dirs (and ablespaces)
> +
On Sat, Oct 28, 2017 at 4:52 PM, Chris Travers wrote:
> There are still some cleanup bits needed here but I wanted to get feedback
> on my general direction.
>
> I hope to submit for commit fest soon if the general feedback is good.
I think you should submit to the CommitFest regardless, to incre