Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-11-28 Thread Nathan Boley
>> Version of patch with few more comments and some fixes. > > Where are we on the idea of better statistics for arrays? I need to finish reviewing the patch: I'll try to send in something tomorrow night. So far it looks good. Best, Nathan -- Sent via pgsql-hackers mailing list (pgsql-hackers@p

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-11-28 Thread Bruce Momjian
Alexander Korotkov wrote: > Version of patch with few more comments and some fixes. Where are we on the idea of better statistics for arrays? -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-10-15 Thread Alexander Korotkov
Hi! Thanks for your attention to my patch! On Sat, Oct 15, 2011 at 2:47 PM, Nathan Boley wrote: > > Looking now, I see that Alexander wasn't Cc'd on the review, so it's > > possible he missed the message? > > > > We've corresponded off list and have discussed my review at some length. > > Alex

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-10-15 Thread Nathan Boley
> Looking now, I see that Alexander wasn't Cc'd on the review, so it's > possible he missed the message? > We've corresponded off list and have discussed my review at some length. Alex submitted an updated patch on Sep 22 to me personally ( although not to the list? Alex? ), with the promise of a

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-10-14 Thread Robert Haas
On Fri, Oct 14, 2011 at 3:24 PM, Bruce Momjian wrote: > Alexander Korotkov wrote: >> Version of patch with few more comments and some fixes. The CommitFest app page is here. https://commitfest.postgresql.org/action/patch_view?id=539 It was reviewed in July by Nate Boley, and never updated. Loo

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-10-14 Thread Bruce Momjian
Alexander Korotkov wrote: > Version of patch with few more comments and some fixes. Where are we on this? -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-06-14 Thread Alexander Korotkov
Version of patch with few more comments and some fixes. -- With best regards, Alexander Korotkov. arrayanalyze-0.4.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-06-13 Thread Alexander Korotkov
On Mon, Jun 13, 2011 at 8:16 AM, Robert Haas wrote: > If the data type is hashable, you could consider building a hash table > on the MCVs and then do a probe for each element in the array. I > think that's better than the other way around because there can't be > more than 10k MCVs, whereas the

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-06-12 Thread Robert Haas
On Sun, Jun 12, 2011 at 12:17 PM, Alexander Korotkov wrote: > I'm worrying about perfomance of "column <@ const" estimation. It takes > O(m*(n+m)) of time, where m - const length and n - statistics target. > Probably, it can be too slow is some some cases. Hmm, that doesn't sound terribly promisi

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-06-12 Thread Alexander Korotkov
On Fri, Jun 10, 2011 at 9:03 PM, Simon Riggs wrote: > Initial comments are that the code is well structured and I doubt > there will be problems at the code level. Looks like a good patch. > I'm worrying about perfomance of "column <@ const" estimation. It takes O(m*(n+m)) of time, where m - cons

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-06-10 Thread Simon Riggs
On Mon, May 23, 2011 at 6:54 PM, Alexander Korotkov wrote: > Second version of patch attached. Main changes: > 1) ANY and ALL keywords handling. > 2) Collecting statistics of array length. It is used in "column <@ const". > 3) Relatively accurate estimation of "column <@ const" selectivity. This

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-05-23 Thread Alexander Korotkov
I forgot to commit before diff. Here is correct version. -- With best regards, Alexander Korotkov. arrayanalyze-0.2.1.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgre

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-05-23 Thread Alexander Korotkov
Second version of patch attached. Main changes: 1) ANY and ALL keywords handling. 2) Collecting statistics of array length. It is used in "column <@ const". 3) Relatively accurate estimation of "column <@ const" selectivity. This estimation is most hard part of patch. I'm warrying that there could

Re: [HACKERS] WIP: collect frequency statistics for arrays

2011-02-24 Thread Robert Haas
On Wed, Feb 23, 2011 at 10:00 AM, Alexander Korotkov wrote: > WIP patch of statistics collection for arrays is attached. Please add this patch to the currently open CommitFest at https://commitfest.postgresql.org/action/commitfest_view/open -- Robert Haas EnterpriseDB: http://www.enterprisedb.