Re: [HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?
Hi, On 2015-09-25 17:39:41 +0530, Rushabh Lathia wrote: > PFA patch to fix the hint message. The patched missed updating the regression test output files ;) Committed and backpatched back to 9.4. Thanks! - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?
Thanks Andres. PFA patch to fix the hint message. On Fri, Sep 25, 2015 at 5:34 PM, Andres Freund wrote: > Hi, > > On 2015-09-25 17:32:39 +0530, Rushabh Lathia wrote: > > I am just wondering why pg_create_physical_replication_slot() can't take > > CAPITAL LETTERS into slot_name ? > > Windows. And OSX. Specifically case-insensitive filenames. > > > If its by design then was should atleast change the hint into > > ReplicationSlotValidateName() which says: "Replication slot names may > only > > contain letters, numbers, and the underscore character." > > We could add a 'lower case' in there. > > Greetings, > > Andres Freund > Regards, Rushabh Lathia www.EnterpriseDB.com slot_name_hint_message_change.patch Description: application/download -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Why can't we used CAPITAL LETTERS into replication slot_name?
Hi, On 2015-09-25 17:32:39 +0530, Rushabh Lathia wrote: > I am just wondering why pg_create_physical_replication_slot() can't take > CAPITAL LETTERS into slot_name ? Windows. And OSX. Specifically case-insensitive filenames. > If its by design then was should atleast change the hint into > ReplicationSlotValidateName() which says: "Replication slot names may only > contain letters, numbers, and the underscore character." We could add a 'lower case' in there. Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
