Re: [HACKERS] Wrong definition of pgwin32_bind.

2016-04-14 Thread Tom Lane 
Michael Paquier  writes:
> On Thu, Apr 14, 2016 at 5:15 PM, Kyotaro HORIGUCHI
>  wrote:
>> The third parameter should be int, not int*. It might have been
>> confused with pgwin32_accept.

> Nice catch.

David Rowley reported this a bit earlier.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Wrong definition of pgwin32_bind.

2016-04-14 Thread Michael Paquier 
On Thu, Apr 14, 2016 at 5:15 PM, Kyotaro HORIGUCHI
 wrote:
> Hello.
>
> VC complains that pgwin32_bind() had a parameter differs in
> levels of indirection from definition. pgwin32_bind() in
> src/backend/port/win32/socket.c is defined as the following.
>
>> int pgwin32_bind(SOCKET s, struct sockaddr * addr, int *addrlen);
>
> The third parameter should be int, not int*. It might have been
> confused with pgwin32_accept.
>
> The attached patch fixes this.

Nice catch.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers