Re: [HACKERS] autocomplete - SELECT fx

2012-07-19 Thread Peter Eisentraut
On tis, 2012-07-10 at 07:29 -0700, Josh Kupershmidt wrote: > On Sat, Jul 7, 2012 at 5:43 PM, Noah Misch wrote: > > I like the patch, as far as it goes. It's the natural addition to the > > completions we already offer; compare the simplistic completion after WHERE. > > Like Pavel and Robert, I th

Re: [HACKERS] autocomplete - SELECT fx

2012-07-10 Thread Josh Kupershmidt
On Sat, Jul 7, 2012 at 5:43 PM, Noah Misch wrote: > I like the patch, as far as it goes. It's the natural addition to the > completions we already offer; compare the simplistic completion after WHERE. > Like Pavel and Robert, I think a delightful implementation of tab completion > for SELECT stat

Re: [HACKERS] autocomplete - SELECT fx

2012-07-07 Thread Noah Misch
On Thu, Jul 05, 2012 at 06:43:09PM -0700, Josh Kupershmidt wrote: > On Mon, Jul 2, 2012 at 1:13 AM, Pavel Stehule wrote: > > > I tested Peter's patch and it works well. > > I liked it as well. But I'm not sure what should happen with the patch > now. It seems like it'd be commit-ready with just

Re: [HACKERS] autocomplete - SELECT fx

2012-07-05 Thread Pavel Stehule
2012/7/6 Josh Kupershmidt : > On Mon, Jul 2, 2012 at 1:13 AM, Pavel Stehule wrote: > >> I tested Peter's patch and it works well. > > I liked it as well. But I'm not sure what should happen with the patch > now. It seems like it'd be commit-ready with just a tweak or two to > the query as I noted

Re: [HACKERS] autocomplete - SELECT fx

2012-07-05 Thread Josh Kupershmidt
On Mon, Jul 2, 2012 at 1:13 AM, Pavel Stehule wrote: > I tested Peter's patch and it works well. I liked it as well. But I'm not sure what should happen with the patch now. It seems like it'd be commit-ready with just a tweak or two to the query as I noted in my last mail, but Tom did seem oppos