Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-10-01 Thread Joshua Brindle
Robert Haas wrote: On Tue, Sep 27, 2011 at 6:30 PM, Tom Lanet...@sss.pgh.pa.us wrote: snip If I have to break up the recipe with annotations like run this part as root and then these commands no longer need root, I don't think that's going to be an improvement over either of the above.

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Kohei KaiGai
2011/9/26 Tom Lane t...@sss.pgh.pa.us: Kohei KaiGai kai...@kaigai.gr.jp writes: How about this fix on regression test of sepgsql? IMO, the fundamental problem with the sepgsql regression tests is that they think they don't need to play by the rules that apply to every other PG regression

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Tom Lane
I wrote: I think it should be possible to still use all the existing testing infrastructure if the check/test script does something like make REGRESS=label dml misc check I've now worked through the process of actually running the sepgsql regression tests, and I must say that I had no

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Robert Haas
On Tue, Sep 27, 2011 at 3:39 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: I think it should be possible to still use all the existing testing infrastructure if the check/test script does something like       make REGRESS=label dml misc check I've now worked through the process of actually

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Sep 27, 2011 at 3:39 PM, Tom Lane t...@sss.pgh.pa.us wrote: Accordingly, the attached patch does what I suggested above, namely dike out the Makefile's knowledge of how to run the regression tests and put it into the chkselinuxenv script.

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Robert Haas
On Tue, Sep 27, 2011 at 6:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: I have not touched the documentation, either.  One thing I'd like to do is adjust both the SGML documentation and the hints printed by the script to uniformly use sudo ...root-privileged-command... rather than recommending use

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-26 Thread Kohei KaiGai
2011/9/26 Tom Lane t...@sss.pgh.pa.us: As a stopgap, what about removing sepgsql from the list of contrib modules tested by make -C contrib check?  (I haven't looked at exactly how ugly it might be to do that, nor whether we'd have to also disable installcheck from recursing to sepgsql.) Is

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-26 Thread Peter Eisentraut
On sön, 2011-09-25 at 23:49 -0400, Robert Haas wrote: In fact, I've been wondering if we ought to go a step further and not recurse into the sepgsql directory for *any* of the targets. Then we could get rid of the associated configure option, which no longer serves any other purpose, and just

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-26 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On sön, 2011-09-25 at 23:49 -0400, Robert Haas wrote: In fact, I've been wondering if we ought to go a step further and not recurse into the sepgsql directory for *any* of the targets. Then we could get rid of the associated configure option, which no

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-26 Thread Robert Haas
On Mon, Sep 26, 2011 at 10:04 AM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: On sön, 2011-09-25 at 23:49 -0400, Robert Haas wrote: In fact, I've been wondering if we ought to go a step further and not recurse into the sepgsql directory for *any* of the targets.

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-26 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Sep 26, 2011 at 10:04 AM, Tom Lane t...@sss.pgh.pa.us wrote: Another possibility is to remove the Makefile's knowledge of how to run the tests, and change chkselinuxenv into something that both verifies the environment and then launches the

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-26 Thread Kohei KaiGai
2011/9/26 Tom Lane t...@sss.pgh.pa.us: Robert Haas robertmh...@gmail.com writes: On Mon, Sep 26, 2011 at 10:04 AM, Tom Lane t...@sss.pgh.pa.us wrote: Another possibility is to remove the Makefile's knowledge of how to run the tests, and change chkselinuxenv into something that both verifies

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-26 Thread Robert Haas
On Mon, Sep 26, 2011 at 11:03 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Sep 26, 2011 at 10:04 AM, Tom Lane t...@sss.pgh.pa.us wrote: Another possibility is to remove the Makefile's knowledge of how to run the tests, and change chkselinuxenv into

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-26 Thread Kohei KaiGai
How about this fix on regression test of sepgsql? It disables to launch regression test together with other modules, and adds its own build target sepgsql-installcheck that launches chkselinuxenv script then pg_regress command as currently we are doing. It allows users to launch regression test

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-26 Thread Tom Lane
Kohei KaiGai kai...@kaigai.gr.jp writes: How about this fix on regression test of sepgsql? IMO, the fundamental problem with the sepgsql regression tests is that they think they don't need to play by the rules that apply to every other PG regression test. I don't think this patch is fixing that

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-25 Thread Robert Haas
On Sun, Sep 25, 2011 at 9:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: As a stopgap, what about removing sepgsql from the list of contrib modules tested by make -C contrib check? +1. In fact, I've been wondering if we ought to go a step further and not recurse into the sepgsql directory for *any*

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-25 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sun, Sep 25, 2011 at 9:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: As a stopgap, what about removing sepgsql from the list of contrib modules tested by make -C contrib check? +1. In fact, I've been wondering if we ought to go a step further and not

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-25 Thread Robert Haas
On Mon, Sep 26, 2011 at 12:06 AM, Tom Lane t...@sss.pgh.pa.us wrote: Then we could get rid of the associated configure option, which no longer serves any other purpose, and just say that if you want to build (or regression-test) sepgsql, well, you gotta go to that directory and do it by hand.