On Wed, Jul 27, 2016 at 10:09 AM, Amit Kapila wrote:
> On Wed, Jul 27, 2016 at 6:46 PM, Robert Haas wrote:
>> On Wed, Jul 27, 2016 at 2:20 AM, Amit Kapila wrote:
>>> Okay, that makes sense to me apart from minor issue reported by
>>> Andrew. I think we might want to slightly rephrase the commen
On Wed, Jul 27, 2016 at 6:46 PM, Robert Haas wrote:
> On Wed, Jul 27, 2016 at 2:20 AM, Amit Kapila wrote:
>> Okay, that makes sense to me apart from minor issue reported by
>> Andrew. I think we might want to slightly rephrase the comments on
>> top of copyParamList() which indicates only about
On Wed, Jul 27, 2016 at 2:20 AM, Amit Kapila wrote:
> Okay, that makes sense to me apart from minor issue reported by
> Andrew. I think we might want to slightly rephrase the comments on
> top of copyParamList() which indicates only about dynamic parameter
> hooks.
I don't see why it needs to be
On Wed, Jul 27, 2016 at 12:25 AM, Andrew Gierth
wrote:
>> "Robert" == Robert Haas writes:
> Robert> So I think we instead ought to fix it as in the attached.
>
> Robert>if (retval->paramMask != NULL &&
> Robert> - !bms_is_member(i, retval->paramMask))
>
On Wed, Jul 27, 2016 at 2:03 AM, Robert Haas wrote:
> On Fri, Jul 8, 2016 at 2:28 AM, Amit Kapila wrote:
>> On Tue, May 31, 2016 at 10:10 PM, Robert Haas wrote:
>>> On Fri, May 27, 2016 at 6:07 PM, Andrew Gierth
>>> wrote:
copyParamList does not respect from->paramMask, in what looks to me
> "Robert" == Robert Haas writes:
Robert> So I think we instead ought to fix it as in the attached.
Robert>if (retval->paramMask != NULL &&
Robert> - !bms_is_member(i, retval->paramMask))
Robert> + !bms_is_member(i, from->paramMas
On Fri, Jul 8, 2016 at 2:28 AM, Amit Kapila wrote:
> On Tue, May 31, 2016 at 10:10 PM, Robert Haas wrote:
>> On Fri, May 27, 2016 at 6:07 PM, Andrew Gierth
>> wrote:
>>> copyParamList does not respect from->paramMask, in what looks to me like
>>> an obvious oversight:
>>>
>>> retval->paramMa
On Tue, May 31, 2016 at 10:10 PM, Robert Haas wrote:
> On Fri, May 27, 2016 at 6:07 PM, Andrew Gierth
> wrote:
>> copyParamList does not respect from->paramMask, in what looks to me like
>> an obvious oversight:
>>
>> retval->paramMask = NULL;
>> [...]
>> /* Ignore parameters we don't
On Fri, May 27, 2016 at 6:07 PM, Andrew Gierth
wrote:
> copyParamList does not respect from->paramMask, in what looks to me like
> an obvious oversight:
>
> retval->paramMask = NULL;
> [...]
> /* Ignore parameters we don't need, to save cycles and space. */
> if (retval->paramM
