Re: [HACKERS] experiences with autocommit functionality in 7.3

2002-10-13 Thread Tom Lane

Barry Lind [EMAIL PROTECTED] writes:
 Below is the current behavior (based on a fresh pull from cvs this morning):
 Current State   ActionEnd State
 ACon and NITset ACon  ACon and NIT
  set ACoff ACoff and IT*

Bruce was supposed to fix this.  We agreed that a SET command would
never initiate a transaction block on its own.  Looks like it's not
there yet --- but IMHO the behavior should be

ACon and NITset ACon  ACon and NIT
 set ACoff ACoff and NIT
ACon and IT set ACon  ACon and IT
 set ACoff ACoff and IT*
ACon and IT*set ACon  ACon and IT*
 set ACoff ACoff and IT
ACoff and NIT   set ACon  ACon and NIT
 set ACoff ACoff and NIT
ACoff and ITset ACon  ACon and IT*
 set ACoff ACoff and IT
ACoff and IT*   set ACon  ACon and IT
 set ACoff ACoff and IT*

Will that resolve your concern?

regards, tom lane

---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster



Re: [HACKERS] experiences with autocommit functionality in 7.3

2002-10-13 Thread Tom Lane

I said:
 Bruce was supposed to fix this.  We agreed that a SET command would
 never initiate a transaction block on its own.  Looks like it's not
 there yet ---

Now it is.  Give it another try ...

regards, tom lane

---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/users-lounge/docs/faq.html



Re: [HACKERS] experiences with autocommit functionality in 7.3

2002-10-13 Thread Bruce Momjian

Tom Lane wrote:
 Barry Lind [EMAIL PROTECTED] writes:
  Below is the current behavior (based on a fresh pull from cvs this morning):
  Current State   ActionEnd State
  ACon and NITset ACon  ACon and NIT
   set ACoff ACoff and IT*
 
 Bruce was supposed to fix this.  We agreed that a SET command would
 never initiate a transaction block on its own.  Looks like it's not
 there yet --- but IMHO the behavior should be

Well, I thought I did it, and it did work on my limited number of test
cases.  Seems you got it fully working.

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]



Re: [HACKERS] experiences with autocommit functionality in 7.3

2002-10-13 Thread Tom Lane

Bruce Momjian [EMAIL PROTECTED] writes:
 Well, I thought I did it, and it did work on my limited number of test
 cases.  Seems you got it fully working.

Actually, it failed for me (and evidently for Barry) on exactly the test
case you posted along with the patch.  You said

 test= set autocommit = off;
 SET
 test= commit;
 WARNING:  COMMIT: no transaction in progress
 COMMIT

but in fact I saw the COMMIT succeeding without complaint.  I was
meaning to ask you just what code you'd tested, because this morning's
CVS tip did *not* behave as above.

regards, tom lane

---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/users-lounge/docs/faq.html



Re: [HACKERS] experiences with autocommit functionality in 7.3

2002-10-13 Thread Bruce Momjian

Tom Lane wrote:
 Bruce Momjian [EMAIL PROTECTED] writes:
  Well, I thought I did it, and it did work on my limited number of test
  cases.  Seems you got it fully working.
 
 Actually, it failed for me (and evidently for Barry) on exactly the test
 case you posted along with the patch.  You said
 
  test= set autocommit = off;
  SET
  test= commit;
  WARNING:  COMMIT: no transaction in progress
  COMMIT
 
 but in fact I saw the COMMIT succeeding without complaint.  I was
 meaning to ask you just what code you'd tested, because this morning's
 CVS tip did *not* behave as above.

I am stumped myself as well.  I still have the CVS of my old code, and
it fails just as you saw, but I know I tested it and copied that into
the email via cut/paste so my only guess is that I tweaked something
after I ran the test and if broke something else.  If you got it all
working now, I won't research further.

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/users-lounge/docs/faq.html