Re: [HACKERS] heap_xlog_lock forgets to reset HEAP_XMAX_INVALID

2016-07-15 Thread Andres Freund
On 2016-07-15 17:43:44 -0400, Alvaro Herrera wrote: > Andres Freund wrote: > > On 2016-07-15 17:23:57 -0400, Alvaro Herrera wrote: > > > > Maybe we should change fix_infomask_from_infobits() to reset > > > HEAP_XMAX_BITS | HEAP_MOVED too (and HEAP_KEYS_UPDATED I suppose), to > > > avoid doing it

Re: [HACKERS] heap_xlog_lock forgets to reset HEAP_XMAX_INVALID

2016-07-15 Thread Alvaro Herrera
Andres Freund wrote: > On 2016-07-15 17:23:57 -0400, Alvaro Herrera wrote: > > Maybe we should change fix_infomask_from_infobits() to reset > > HEAP_XMAX_BITS | HEAP_MOVED too (and HEAP_KEYS_UPDATED I suppose), to > > avoid doing it in each callsite. > > Yea, I was thinking of that as well. But

Re: [HACKERS] heap_xlog_lock forgets to reset HEAP_XMAX_INVALID

2016-07-15 Thread Andres Freund
On 2016-07-15 17:23:57 -0400, Alvaro Herrera wrote: > Andres Freund wrote: > > > While validating my patch for > > http://archives.postgresql.org/message-id/20160714060607.klwgq2qr7egt3zrr%40alap3.anarazel.de > > I noticed that the standby's infomask still had HEAP_XMAX_INVALID set > > after

Re: [HACKERS] heap_xlog_lock forgets to reset HEAP_XMAX_INVALID

2016-07-15 Thread Alvaro Herrera
Andres Freund wrote: > While validating my patch for > http://archives.postgresql.org/message-id/20160714060607.klwgq2qr7egt3zrr%40alap3.anarazel.de > I noticed that the standby's infomask still had HEAP_XMAX_INVALID set > after replaying a XLOG_HEAP_LOCK record. > > That's bad, but not really