Re: [HACKERS] includeifexists in configuration file

2011-12-15 Thread Greg Smith
On 12/12/2011 04:47 PM, Andrew Dunstan wrote: I have briefly looked at the code (but not tried to apply or build it), and modulo the naming issue it looks OK to me. Unless there is some other issue let's just get it applied. It looks like almost a no-brainer to me. It isn't very fancy, but is

Re: [HACKERS] includeifexists in configuration file

2011-12-15 Thread Andrew Dunstan
On 12/15/2011 06:54 AM, Greg Smith wrote: On 12/12/2011 04:47 PM, Andrew Dunstan wrote: I have briefly looked at the code (but not tried to apply or build it), and modulo the naming issue it looks OK to me. Unless there is some other issue let's just get it applied. It looks like almost a

Re: [HACKERS] includeifexists in configuration file

2011-12-15 Thread Greg Smith
On 12/15/2011 08:16 PM, Andrew Dunstan wrote: I changed the elog() call to use ereport(): you're not supposed to use elog() for things we expect might well happen and cause log entries - see bottom of http://www.postgresql.org/docs/current/static/error-message-reporting.html. I've probably

Re: [HACKERS] includeifexists in configuration file

2011-12-12 Thread Greg Smith
On 11/16/2011 10:19 AM, Robert Haas wrote: I haven't read the code yet, but just to get the bikeshedding started, I think it might be better to call this include_if_exists rather than running it together as one word. What's going on, it's like this bikeshed just disappeared. I should

Re: [HACKERS] includeifexists in configuration file

2011-12-12 Thread Ross Reedstrom
On Mon, Dec 12, 2011 at 02:24:53PM -0500, Greg Smith wrote: On 11/16/2011 10:19 AM, Robert Haas wrote: I haven't read the code yet, but just to get the bikeshedding started, I think it might be better to call this include_if_exists rather than running it together as one word. What's going

Re: [HACKERS] includeifexists in configuration file

2011-12-12 Thread Andrew Dunstan
On 12/12/2011 02:24 PM, Greg Smith wrote: On 11/16/2011 10:19 AM, Robert Haas wrote: I haven't read the code yet, but just to get the bikeshedding started, I think it might be better to call this include_if_exists rather than running it together as one word. What's going on, it's like this

Re: [HACKERS] includeifexists in configuration file

2011-11-16 Thread Euler Taveira de Oliveira
On 16-11-2011 02:28, Greg Smith wrote: By recent popular request in the ongoing discussion saga around merging the recovery.conf, I've added an includeifexists directive to the postgresql.conf in the attached patch. I'm not following the merging recovery.conf thread but isn't it worth

Re: [HACKERS] includeifexists in configuration file

2011-11-16 Thread Tom Lane
Euler Taveira de Oliveira eu...@timbira.com writes: On 16-11-2011 02:28, Greg Smith wrote: By recent popular request in the ongoing discussion saga around merging the recovery.conf, I've added an includeifexists directive to the postgresql.conf in the attached patch. I'm not following the

Re: [HACKERS] includeifexists in configuration file

2011-11-16 Thread Robert Haas
On Wed, Nov 16, 2011 at 12:28 AM, Greg Smith g...@2ndquadrant.com wrote: By recent popular request in the ongoing discussion saga around merging the recovery.conf, I've added an includeifexists directive to the postgresql.conf in the attached patch. I haven't read the code yet, but just to get