Re: [HACKERS] mb_regress.sh gripes

2011-09-02 Thread Josh Kupershmidt
On Thu, Sep 1, 2011 at 9:25 AM, Robert Haas robertmh...@gmail.com wrote: Committed, with some changes.  I used the new --if-exists option for dropdb rather than doing it as you had it here; I assume this may have been the motivation for that patch. Thanks, and that was indeed one reason I

Re: [HACKERS] mb_regress.sh gripes

2011-09-01 Thread Robert Haas
On Thu, Aug 18, 2011 at 6:19 PM, Josh Kupershmidt schmi...@gmail.com wrote: A few gripes about mb_regress.sh:  1. No exit code is specified, so even if there are differences between results/ and expected/ the script will still return 0.  2. The 'dropdb' command is used to wipe out the utf8