you can't do this sort of thing:
-psql_error("The server (version %s) does not support editing function
source.\n",
+psql_error("The server (version %s) does not support editing
%s.\n",
formatPGVersionNumber(pset.sversion, false,
-
Fabien COELHO writes:
> Here is an attempt at merging some functions which removes 160 lines of
> code.
Pushed with minor adjustments. I thought a couple of variable names
could be better chosen, but mostly, you can't do this sort of thing:
-psql_error("The server (version %s) does
While reviewing Corey's \if patch, I complained that there was some amount
of copy-paste in "psql/command.c".
Here is an attempt at merging some functions which removes 160 lines of
code.
Thank you for the patch. Is this an item for PG11?
Yep.
--
Fabien.
--
Sent via pgsql-hackers mailing
On Wed, Jul 19, 2017 at 2:41 PM, Fabien COELHO wrote:
>
>>> While reviewing Corey's \if patch, I complained that there was some
>>> amount
>>> of copy-paste in "psql/command.c".
>>>
>>> Here is an attempt at merging some functions which removes 160 lines of
>>> code.
>>
>>
>> Thank you for the pat
While reviewing Corey's \if patch, I complained that there was some amount
of copy-paste in "psql/command.c".
Here is an attempt at merging some functions which removes 160 lines of
code.
Thank you for the patch. Is this an item for PG11?
Yes, as it is submitted to CF 2017-09.
--
Fabien.
On Sat, Apr 1, 2017 at 3:04 AM, Fabien COELHO wrote:
>
> Hello,
>
> While reviewing Corey's \if patch, I complained that there was some amount
> of copy-paste in "psql/command.c".
>
> Here is an attempt at merging some functions which removes 160 lines of
> code.
>
Thank you for the patch. Is thi
Hello Victor,
While reviewing Corey's \if patch, I complained that there was some
amount of copy-paste in "psql/command.c".
Here is an attempt at merging some functions which removes 160 lines of
code.
I was looking through your patch. It seems good, the of the functions was
very similar.
On 2017-03-31 21:04, Fabien COELHO wrote:
Hello,
While reviewing Corey's \if patch, I complained that there was some
amount of copy-paste in "psql/command.c".
Here is an attempt at merging some functions which removes 160 lines of
code.
Hello,
I was looking through your patch. It seems good