Re: [HACKERS] missing const it PQexscapeBytea/PQunescapeBytea in 7.3b3
Patch applied, with doc updates by me. Thanks. --- Tommi Mäkitalo wrote: > Hi, > > I just discovered, that there is missing a const when passing a buffer to > PQescapeBytea and PQunescapeBytea. I fixed it and tried to create a usable > diff (I'm not so familar to diff). > > Tommi > > > (resent with the right identity) [ Attachment, skipping... ] [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 5: Have you checked our extensive FAQ? > > http://www.postgresql.org/users-lounge/docs/faq.html -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [HACKERS] missing const it PQexscapeBytea/PQunescapeBytea in 7.3b3
Hi, my "other problems in PQescapeBytea" disappeared. I can't find them any more. I did some testing and all is fine. Tommi Am Sonntag, 3. November 2002 15:50 schrieb Bruce Momjian: > Tommi Mäkitalo wrote: > > Hi, > > > > not really. I can cast it away. Ugly, but it works. > > > > But I think it isn't that big, that it cant go into 7.3? It is really > > very local. It doesn't change anything. It should be very save. > > We are sort of in a code freeze so though it is little, I will keep it > for 7.4. Thanks. > > > I just write another C++-interface and c++ is more strict in checking. > > > > By the way: I think there are other problems in PQescapeBytea. It do not > > work as expected. It seems, than nobody is using it anyway. I am checking > > it right now. I will tell you about my researches soon. > > OK, let me know. -- Dr. Eckhardt + Partner GmbH http://www.epgmbh.de ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [HACKERS] missing const it PQexscapeBytea/PQunescapeBytea in 7.3b3
This has been saved for the 7.4 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Tommi Mäkitalo wrote: > Hi, > > I just discovered, that there is missing a const when passing a buffer to > PQescapeBytea and PQunescapeBytea. I fixed it and tried to create a usable > diff (I'm not so familar to diff). > > Tommi > > > (resent with the right identity) [ Attachment, skipping... ] [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 5: Have you checked our extensive FAQ? > > http://www.postgresql.org/users-lounge/docs/faq.html -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [HACKERS] missing const it PQexscapeBytea/PQunescapeBytea in 7.3b3
Tommi Mäkitalo wrote: > Hi, > > not really. I can cast it away. Ugly, but it works. > > But I think it isn't that big, that it cant go into 7.3? It is really very > local. It doesn't change anything. It should be very save. We are sort of in a code freeze so though it is little, I will keep it for 7.4. Thanks. > > I just write another C++-interface and c++ is more strict in checking. > > By the way: I think there are other problems in PQescapeBytea. It do not work > as expected. It seems, than nobody is using it anyway. I am checking it right > now. I will tell you about my researches soon. OK, let me know. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [HACKERS] missing const it PQexscapeBytea/PQunescapeBytea in 7.3b3
Hi, not really. I can cast it away. Ugly, but it works. But I think it isn't that big, that it cant go into 7.3? It is really very local. It doesn't change anything. It should be very save. I just write another C++-interface and c++ is more strict in checking. By the way: I think there are other problems in PQescapeBytea. It do not work as expected. It seems, than nobody is using it anyway. I am checking it right now. I will tell you about my researches soon. Tommi Am Sonntag, 3. November 2002 02:29 schrieb Bruce Momjian: > Is the missing const a major problem or can I save this patch for 7.4? > > --- > > Tommi Mäkitalo wrote: > > Hi, > > > > I just discovered, that there is missing a const when passing a buffer to > > PQescapeBytea and PQunescapeBytea. I fixed it and tried to create a > > usable diff (I'm not so familar to diff). > > > > Tommi > > > > > > (resent with the right identity) > > [ Attachment, skipping... ] > > [ Attachment, skipping... ] > > > ---(end of broadcast)--- > > TIP 5: Have you checked our extensive FAQ? > > > > http://www.postgresql.org/users-lounge/docs/faq.html ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [HACKERS] missing const it PQexscapeBytea/PQunescapeBytea in 7.3b3
Is the missing const a major problem or can I save this patch for 7.4? --- Tommi Mäkitalo wrote: > Hi, > > I just discovered, that there is missing a const when passing a buffer to > PQescapeBytea and PQunescapeBytea. I fixed it and tried to create a usable > diff (I'm not so familar to diff). > > Tommi > > > (resent with the right identity) [ Attachment, skipping... ] [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 5: Have you checked our extensive FAQ? > > http://www.postgresql.org/users-lounge/docs/faq.html -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
